jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396927 ) Change subject: scripts/imagecopy.py: Change hardcoded Commons Site calls ...................................................................... scripts/imagecopy.py: Change hardcoded Commons Site calls Change hardcoded Commons Site calls (`pywikibot.Site('commons', commons')`) to `Page.site.image_repository()` calls. Change-Id: Id9755f16c778b6cc3428a7a31f635429e013cb8f --- M scripts/imagecopy.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/imagecopy.py b/scripts/imagecopy.py index c58a2df..377f3c6 100644 --- a/scripts/imagecopy.py +++ b/scripts/imagecopy.py @@ -226,6 +226,7 @@ def __init__(self, imagePage, newname, category, delete_after_done=False): """Constructor.""" self.imagePage = imagePage + self.image_repo = imagePage.site.image_repository() self.newname = newname self.category = category self.delete_after_done = delete_after_done @@ -272,11 +273,11 @@ bot = UploadRobot(url=self.imagePage.fileUrl(), description=CH, useFilename=self.newname, keepFilename=True, verifyDescription=False, ignoreWarning=True, - targetSite=pywikibot.Site('commons', 'commons')) + targetSite=self.image_repo) bot.run() # Should check if the image actually was uploaded - if pywikibot.Page(pywikibot.Site('commons', 'commons'), + if pywikibot.Page(self.image_repo, u'Image:' + self.newname).exists(): # Get a fresh copy, force to get the page so we dont run into edit # conflicts @@ -547,7 +548,7 @@ # Check if the image already exists CommonsPage = pywikibot.Page( - pywikibot.Site('commons', 'commons'), + imagepage.site.image_repository(), u'File:' + newname) if not CommonsPage.exists(): break -- To view, visit https://gerrit.wikimedia.org/r/396927 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9755f16c778b6cc3428a7a31f635429e013cb8f Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Rafidaslam &lt;rafidteam(a)gmail.com&gt; Gerrit-Reviewer: Framawiki &lt;framawiki(a)tools.wmflabs.org&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Rafidaslam &lt;rafidteam(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>