jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377677 ) Change subject: tests.aspects.TestCase.has_site_user: Support '*' as family name ...................................................................... tests.aspects.TestCase.has_site_user: Support '*' as family name Pywikibot supports '*' as family name since a10cbb30ed58085c754519e066c72d. Tests that require a username should support this new method of specifying usernames in userconfig.py and should not be skipped. Bug: T120334 Change-Id: I278d70127bfc4f8d26035b74c3ae88dda62e37de --- M tests/aspects.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/aspects.py b/tests/aspects.py index 76fd2b5..9a60cfc 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -1018,7 +1018,8 @@ usernames = config.sysopnames if sysop else config.usernames - return code in usernames[family] or '*' in usernames[family] + return (code in usernames[family] or '*' in usernames[family] or + code in usernames['*'] or '*' in usernames['*']) def __init__(self, *args, **kwargs): """Constructor.""" -- To view, visit https://gerrit.wikimedia.org/r/377677 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278d70127bfc4f8d26035b74c3ae88dda62e37de Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>