jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378380 )
Change subject: _http_param_string.__doc__: Add a note about parameters not being sorted
......................................................................
_http_param_string.__doc__: Add a note about parameters not being sorted
Change-Id: I5e2295c3a9d0e6150dd5640f18e2101867d0aed1
---
M pywikibot/data/api.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index a88d9e4..b9ff3ae 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -1771,6 +1771,10 @@
Return the parameters as a HTTP URL query fragment.
URL encodes the parameters provided by _encoded_items()
+
+ @note: Not all parameters are sorted, therefore for two given
+ CachedRequest objects with equal _params, the result of
+ _http_param_string() is not necessarily equal.
"""
return encode_url(self._encoded_items())
--
To view, visit
https://gerrit.wikimedia.org/r/378380
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2295c3a9d0e6150dd5640f18e2101867d0aed1
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>