jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/469405 )
Change subject: [cleanup] Fix W504 error in scripts/welcome.py ......................................................................
[cleanup] Fix W504 error in scripts/welcome.py
Fixed breaking of line after a binary operator. So the line break should happen before it with the line wrapped in parentheses.
In case the operator falls on the same line with the next line, do 1 more 4 spaces indentation. This patch does that!
Bug: T207836 Depends-On: I203077c45b6fba00502e3e8c536da5a049493acd Change-Id: Iac640afd147ce3d100bd23560f5a5c8087b467c1 --- M scripts/welcome.py 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Xqt: Looks good to me, approved Dvorapa: Looks good to me, but someone else must approve jenkins-bot: Verified
diff --git a/scripts/welcome.py b/scripts/welcome.py index 0871dfd..496d0e8 100755 --- a/scripts/welcome.py +++ b/scripts/welcome.py @@ -794,11 +794,11 @@ if self.site.family.name != 'wikinews': welcome_text = (welcome_text % choice(self.defineSign())) - if self.site.family.name != 'wiktionary' or \ - self.site.code != 'it': + if (self.site.family.name != 'wiktionary' + or self.site.code != 'it'): welcome_text += timeselected - elif (self.site.family.name != 'wikinews' and - self.site.code != 'it'): + elif (self.site.family.name != 'wikinews' + and self.site.code != 'it'): welcome_text = (welcome_text % globalvar.defaultSign) final_text = i18n.translate(
pywikibot-commits@lists.wikimedia.org