jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved Dvorapa: Looks good to me, but someone else must approve jenkins-bot: Verified
[cleanup] Fix W504 error in scripts/welcome.py

Fixed breaking of line after a binary operator. So the line
break should happen before it with the line wrapped in parentheses.

In case the operator falls on the same line with the next line, do
1 more 4 spaces indentation. This patch does that!

Bug: T207836
Depends-On: I203077c45b6fba00502e3e8c536da5a049493acd
Change-Id: Iac640afd147ce3d100bd23560f5a5c8087b467c1
---
M scripts/welcome.py
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/welcome.py b/scripts/welcome.py
index 0871dfd..496d0e8 100755
--- a/scripts/welcome.py
+++ b/scripts/welcome.py
@@ -794,11 +794,11 @@
if self.site.family.name != 'wikinews':
welcome_text = (welcome_text
% choice(self.defineSign()))
- if self.site.family.name != 'wiktionary' or \
- self.site.code != 'it':
+ if (self.site.family.name != 'wiktionary'
+ or self.site.code != 'it'):
welcome_text += timeselected
- elif (self.site.family.name != 'wikinews' and
- self.site.code != 'it'):
+ elif (self.site.family.name != 'wikinews'
+ and self.site.code != 'it'):
welcome_text = (welcome_text
% globalvar.defaultSign)
final_text = i18n.translate(

To view, visit change 469405. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac640afd147ce3d100bd23560f5a5c8087b467c1
Gerrit-Change-Number: 469405
Gerrit-PatchSet: 5
Gerrit-Owner: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)