jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/495172 )
Change subject: [bugfix] Remove test for 'id' in rcinfo.keys() ......................................................................
[bugfix] Remove test for 'id' in rcinfo.keys()
It is not safe that rcinfo contains this key
Bug: T217877 Change-Id: I7ac1830fb32b5557a5a455a3e322a23048052d0c --- M tests/pagegenerators_tests.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: D3r1ck01: Looks good to me, but someone else must approve Dvorapa: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 7440e6a..041ebcf 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -1582,7 +1582,7 @@ self.assertEqual(rcinfo['server_name'], site.hostname()) self.assertEqual(rcinfo['wiki'], site.dbName())
- for key in ['id', 'type', 'namespace', 'title', 'comment', + for key in ['type', 'namespace', 'title', 'comment', 'timestamp', 'user', 'bot']: self.assertIn(key, rcinfo.keys())
pywikibot-commits@lists.wikimedia.org