jenkins-bot merged this change.

View Change

Approvals: D3r1ck01: Looks good to me, but someone else must approve Dvorapa: Looks good to me, approved jenkins-bot: Verified
[bugfix] Remove test for 'id' in rcinfo.keys()

It is not safe that rcinfo contains this key

Bug: T217877
Change-Id: I7ac1830fb32b5557a5a455a3e322a23048052d0c
---
M tests/pagegenerators_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 7440e6a..041ebcf 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1582,7 +1582,7 @@
self.assertEqual(rcinfo['server_name'], site.hostname())
self.assertEqual(rcinfo['wiki'], site.dbName())

- for key in ['id', 'type', 'namespace', 'title', 'comment',
+ for key in ['type', 'namespace', 'title', 'comment',
'timestamp', 'user', 'bot']:
self.assertIn(key, rcinfo.keys())


To view, visit change 495172. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ac1830fb32b5557a5a455a3e322a23048052d0c
Gerrit-Change-Number: 495172
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)