jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] ModuleDeprecationWrapper: Update __dict__
......................................................................
[FIX] ModuleDeprecationWrapper: Update __dict__
On `__setattr__` calls, it did not update `__dict__` which caused it to return
the old entry from the `__dict__` instead of the entry from the module.
Change-Id: If366d01748f8743394635bfed47308389b3aec27
---
M pywikibot/tools/__init__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py
index 1abf204..fa07047 100644
--- a/pywikibot/tools/__init__.py
+++ b/pywikibot/tools/__init__.py
@@ -1507,6 +1507,7 @@
def __setattr__(self, attr, value):
"""Set the value of the wrapped module."""
+ self.__dict__[attr] = value
setattr(self._module, attr, value)
def __getattr__(self, attr):
--
To view, visit
https://gerrit.wikimedia.org/r/238651
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If366d01748f8743394635bfed47308389b3aec27
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>