jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] tests: Check the HTTPS connection
......................................................................
[FIX] tests: Check the HTTPS connection
The certificates for `wdq.wmflabs.org` and `wikistats.wmflabs.org` have expired
and although the hostname is checked before the test, it only checks the HTTP
connection which is still fine and thus it won't skip it. This changes the
tested hostnames to the actual hostnames tested.
Change-Id: I96b9af0d8428145e084249cb6f0d6c4756b94a93
---
M tests/wikidataquery_tests.py
M tests/wikistats_tests.py
2 files changed, 2 insertions(+), 10 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/wikidataquery_tests.py b/tests/wikidataquery_tests.py
index 81ed4f9..b5ee548 100644
--- a/tests/wikidataquery_tests.py
+++ b/tests/wikidataquery_tests.py
@@ -231,11 +231,7 @@
"""Test slow WikiDataQuery API functions."""
- sites = {
- 'wdq': {
- 'hostname': 'wdq.wmflabs.org',
- },
- }
+ hostname = 'https://wdq.wmflabs.org/api'
def testQueryApiGetter(self):
"""Test that we can actually retreive data and that caching
works."""
diff --git a/tests/wikistats_tests.py b/tests/wikistats_tests.py
index 6f2dff3..f9e727f 100644
--- a/tests/wikistats_tests.py
+++ b/tests/wikistats_tests.py
@@ -24,11 +24,7 @@
"""Test WikiStats dump."""
- sites = {
- 'wikistats': {
- 'hostname': 'wikistats.wmflabs.org',
- },
- }
+ hostname = 'https://wikistats.wmflabs.org/api.php'
def test_sort(self):
"""Test sorted results."""
--
To view, visit
https://gerrit.wikimedia.org/r/238457
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96b9af0d8428145e084249cb6f0d6c4756b94a93
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>