Pywikibot-commits October 2017

pywikibot-commits@lists.wikimedia.org

2 participants
58 discussions

[Gerrit] pywikibot[refs/meta/config]: Fix submodules being updated
by Merlijn van Deen (Code Review) 14 Oct '17

14 Oct '17

Merlijn van Deen has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384207 ) Change subject: Fix submodules being updated ...................................................................... Fix submodules being updated Bug: T178067 Change-Id: Id6041f44bebfa7f7bafa85b3f35e05020a6ffe0d --- M project.config 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Merlijn van Deen: Verified; Looks good to me, approved Xqt: Looks good to me, but someone else must approve diff --git a/project.config b/project.config index a89bcf0..c3e1223 100644 --- a/project.config +++ b/project.config @@ -6,4 +6,15 @@ owner = group pywikibot submit = group pywikibot pushSignedTag = group pywikibot -[receive] +[allowSuperproject "pywikibot"] + all = refs/heads/*:refs/heads/* +[allowSuperproject "pywikibot/core"] + all = refs/heads/*:refs/heads/* +[allowSuperproject "pywikibot/i18n"] + all = refs/heads/*:refs/heads/* +[subscribe "pywikibot"] + refs = refs/heads/*:refs/heads/* +[subscribe "pywikibot/core"] + refs = refs/heads/*:refs/heads/* +[subscribe "pywikibot/i18n"] + refs = refs/heads/*:refs/heads/* -- To view, visit https://gerrit.wikimedia.org/r/384207 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6041f44bebfa7f7bafa85b3f35e05020a6ffe0d Gerrit-PatchSet: 3 Gerrit-Project: pywikibot Gerrit-Branch: refs/meta/config Gerrit-Owner: Paladox <thomasmulhall410(a)yahoo.com> Gerrit-Reviewer: Chad <chadh(a)wikimedia.org> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Hashar <hashar(a)free.fr> Gerrit-Reviewer: Legoktm <legoktm(a)member.fsf.org> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Nikerabbit <niklas.laxstrom(a)gmail.com> Gerrit-Reviewer: Paladox <thomasmulhall410(a)yahoo.com> Gerrit-Reviewer: Reedy <reedy(a)wikimedia.org> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] pywikibot/core[master]: page.py: fix docstring of User.rights()
by jenkins-bot (Code Review) 14 Oct '17

14 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384080 ) Change subject: page.py: fix docstring of User.rights() ...................................................................... page.py: fix docstring of User.rights() Change-Id: I85e6e8c2aa6a09459138ef3e9ac5821dc53685a5 --- M pywikibot/page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified Zoranzoki21: Looks good to me, but someone else must approve diff --git a/pywikibot/page.py b/pywikibot/page.py index d15e680..89fe983 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3300,7 +3300,7 @@ return self.getprops(force).get('gender', 'unknown') def rights(self, force=False): - """Return the gender of the user. + """Return user rights. @param force: if True, forces reloading the data from API @type force: bool -- To view, visit https://gerrit.wikimedia.org/r/384080 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85e6e8c2aa6a09459138ef3e9ac5821dc53685a5 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: Add i18n by default in folder script
by jenkins-bot (Code Review) 13 Oct '17

13 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383638 ) Change subject: Add i18n by default in folder script ...................................................................... Add i18n by default in folder script Change-Id: Iee282dd642c58b4125665696cee53b939d6abf30 --- M scripts/i18n 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dvorapa: Looks good to me, but someone else must approve jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/i18n b/scripts/i18n index cd138ef..8924cfd 160000 --- a/scripts/i18n +++ b/scripts/i18n @@ -1 +1 @@ -Subproject commit cd138ef95047e2b4e304d934f640f90e1abf68a3 +Subproject commit 8924cfd5ed3083f70bf68deb75befcc2e19c73ae -- To view, visit https://gerrit.wikimedia.org/r/383638 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee282dd642c58b4125665696cee53b939d6abf30 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Siebrand <siebrand(a)kitano.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: welcome.py: update for srwiki
by jenkins-bot (Code Review) 13 Oct '17

13 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383128 ) Change subject: welcome.py: update for srwiki ...................................................................... welcome.py: update for srwiki report_page and bad_pag parameters changed because SashatoBot is not active report_text parameter added Change-Id: I5426a76a996e3ee4b9ba5b3314c8346c957a1066 --- M scripts/welcome.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Dvorapa: Looks good to me, but someone else must approve Framawiki: Looks good to me, but someone else must approve jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/welcome.py b/scripts/welcome.py index 3baca49..eb1148f 100755 --- a/scripts/welcome.py +++ b/scripts/welcome.py @@ -285,7 +285,7 @@ 'pdc': u'Benutzer:Xqt/Report', 'ru': u'Участник:LatitudeBot/Рапорт', 'sq': u'User:EagleBot/Report', - 'sr': u'User:SashatoBot/Записи', + 'sr': 'User:ZoranBot/Записи', 'zh': u'User:Welcomebot/report', 'zh-yue': u'User:Alexbot/report', } @@ -305,7 +305,7 @@ 'no': u'Bruker:JhsBot/Daarlige ord', 'ru': u'Участник:LatitudeBot/Чёрный список', 'sq': u'User:Eagleal/Bad_names', - 'sr': u'Додавање корисника за проверу', + 'sr': 'User:ZoranBot/лоша корисничка имена', 'zh': u'User:Welcomebot/badname', 'zh-yue': u'User:Welcomebot/badname', } @@ -332,6 +332,7 @@ 'no': u'\n*{{bruker|%s}} ' + timeselected, 'pdc': u'\n*[[Benutzer Diskussion:%s]] ' + timeselected, 'sq': u'\n*[[User:%s]] ' + timeselected, + 'sr': '\n*{{Корисник|%s}}' + timeselected, 'zh': u"\n*{{User|%s}}" + timeselected } } -- To view, visit https://gerrit.wikimedia.org/r/383128 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5426a76a996e3ee4b9ba5b3314c8346c957a1066 Gerrit-PatchSet: 12 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: test_search_where_title: Also look into redirect titles
by jenkins-bot (Code Review) 13 Oct '17

13 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/379164 ) Change subject: test_search_where_title: Also look into redirect titles ...................................................................... test_search_where_title: Also look into redirect titles Bug: T176297 Change-Id: If75126526aaec6408462b500ca828d2e0bb96333 --- M tests/site_tests.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved Zoranzoki21: Looks good to me, but someone else must approve diff --git a/tests/site_tests.py b/tests/site_tests.py index 996389d..3adc9ee 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -1487,7 +1487,11 @@ get_redirects=True, where='title'): self.assertIsInstance(hit, pywikibot.Page) self.assertEqual(hit.namespace(), 0) - self.assertIn('wiki', hit.title().lower()) + try: + self.assertIn('wiki', hit.title().lower()) + except AssertionError: + self.assertTrue(any('wiki' in r.title().lower() for r in + hit.getReferences(redirectsOnly=True))) except pywikibot.data.api.APIError as e: if e.code in ('search-title-disabled', 'gsrsearch-title-disabled'): raise unittest.SkipTest( -- To view, visit https://gerrit.wikimedia.org/r/379164 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75126526aaec6408462b500ca828d2e0bb96333 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: [IMPR] Introduce gender() method for User class
by jenkins-bot (Code Review) 13 Oct '17

13 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383532 ) Change subject: [IMPR] Introduce gender() method for User class ...................................................................... [IMPR] Introduce gender() method for User class gender tag was introduced with mw 1.16 - rewrite site.users to get "gender" and "rights" properties. We may use lists for the usprop porperties as well as the ususers usernames instead of a string with values separated by "|" - add gender method to User class. return "unknown" as a fallback for older mw versions - some tests added Bug: T177916 Change-Id: I04bb67e5ce00295523b686c94bc9519a37972c22 --- M pywikibot/page.py M pywikibot/site.py M tests/user_tests.py 3 files changed, 41 insertions(+), 5 deletions(-) Approvals: Masti: Looks good to me, but someone else must approve Strainu: Looks good to me, approved jenkins-bot: Verified Zoranzoki21: Looks good to me, but someone else must approve Objections: Mpaa: There's a problem with this change, please improve diff --git a/pywikibot/page.py b/pywikibot/page.py index cd8da84..d15e680 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3289,6 +3289,26 @@ """ return self.getprops(force).get('groups', []) + def gender(self, force=False): + """Return the gender of the user. + + @param force: if True, forces reloading the data from API + @type force: bool + @return: return 'male', 'female', or 'unknown' + @rtype: str + """ + return self.getprops(force).get('gender', 'unknown') + + def rights(self, force=False): + """Return the gender of the user. + + @param force: if True, forces reloading the data from API + @type force: bool + @return: return user rights + @rtype: list + """ + return self.getprops(force).get('rights', []) + def getUserPage(self, subpage=u''): """ Return a Page object relative to this user's main page. diff --git a/pywikibot/site.py b/pywikibot/site.py index 5dff0df..ac20cd0 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -4914,12 +4914,14 @@ @param usernames: a list of user names @type usernames: list, or other iterable, of unicodes """ - if not isinstance(usernames, basestring): - usernames = u"|".join(usernames) + usprop = ['blockinfo', 'groups', 'editcount', 'registration', + 'emailable'] + if MediaWikiVersion(self.version()) >= MediaWikiVersion('1.16'): + usprop.append('gender') + if MediaWikiVersion(self.version()) >= MediaWikiVersion('1.17'): + usprop.append('rights') usgen = api.ListGenerator( - "users", ususers=usernames, site=self, - usprop="blockinfo|groups|editcount|registration|emailable" - ) + 'users', ususers=usernames, site=self, usprop=usprop) return usgen @deprecated("Site.randompages()") diff --git a/tests/user_tests.py b/tests/user_tests.py index 6d2940d..96b99d9 100644 --- a/tests/user_tests.py +++ b/tests/user_tests.py @@ -32,6 +32,7 @@ self.assertGreater(user.editCount(), 0) self.assertFalse(user.isBlocked()) self.assertTrue(user.isEmailable()) + self.assertEqual(user.gender(), 'unknown') self.assertIn('userid', user.getprops()) def test_registered_user_without_timestamp(self): @@ -42,6 +43,16 @@ self.assertIsNone(user.registration()) self.assertIsNone(user.getprops()['registration']) self.assertGreater(user.editCount(), 0) + self.assertEqual(user.gender(), 'male') + self.assertIn('userid', user.getprops()) + + def test_female_user(self): + """Test female user.""" + user = User(self.site, 'Alraunenstern') + self.assertTrue(user.isRegistered()) + self.assertFalse(user.isAnonymous()) + self.assertGreater(user.editCount(), 0) + self.assertEqual(user.gender(), 'female') self.assertIn('userid', user.getprops()) def test_anonymous_user(self): @@ -53,6 +64,7 @@ self.assertTrue(user.isAnonymous()) self.assertIsNone(user.registration()) self.assertFalse(user.isEmailable()) + self.assertEqual(user.gender(), 'unknown') self.assertIn('invalid', user.getprops()) def test_unregistered_user(self): @@ -64,6 +76,7 @@ self.assertFalse(user.isAnonymous()) self.assertIsNone(user.registration()) self.assertFalse(user.isEmailable()) + self.assertEqual(user.gender(), 'unknown') self.assertIn('missing', user.getprops()) def test_invalid_user(self): @@ -75,6 +88,7 @@ self.assertFalse(user.isAnonymous()) self.assertIsNone(user.registration()) self.assertFalse(user.isEmailable()) + self.assertEqual(user.gender(), 'unknown') self.assertIn('invalid', user.getprops()) -- To view, visit https://gerrit.wikimedia.org/r/383532 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04bb67e5ce00295523b686c94bc9519a37972c22 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Masti <mastigm(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Strainu <wiki(a)strainu.ro> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: [bugfix] fix flake8-docstrings failure
by jenkins-bot (Code Review) 13 Oct '17

13 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383515 ) Change subject: [bugfix] fix flake8-docstrings failure ...................................................................... [bugfix] fix flake8-docstrings failure - flake8-docstrings failes with pydocstyle 2.1.0 and 2.1.1 Bug: T177912 Change-Id: Ifa583511f1408ce6871d24ec0caa3524dd212a0a --- M tox.ini 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Strainu: Looks good to me, but someone else must approve Dalba: Looks good to me, approved jenkins-bot: Verified Zoranzoki21: Looks good to me, but someone else must approve diff --git a/tox.ini b/tox.ini index 668d4b7..e12ea9b 100644 --- a/tox.ini +++ b/tox.ini @@ -56,7 +56,7 @@ basepython = python2.7 deps = flake8<3 pyflakes >= 1.1 - pydocstyle >= 2.0.0 + pydocstyle == 2.0.0 hacking flake8-docstrings>=1.1.0 flake8-putty>=0.3.2 -- To view, visit https://gerrit.wikimedia.org/r/383515 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa583511f1408ce6871d24ec0caa3524dd212a0a Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Strainu <wiki(a)strainu.ro> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: git ignore cache folder (for windows users) too
by jenkins-bot (Code Review) 07 Oct '17

07 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382670 ) Change subject: git ignore cache folder (for windows users) too ...................................................................... git ignore cache folder (for windows users) too Change-Id: I750203e03d3e0edc622aba5ebffad3f8822664d8 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Huji: Looks good to me, approved jenkins-bot: Verified diff --git a/.gitignore b/.gitignore index cf0b69d..ec60fac 100644 --- a/.gitignore +++ b/.gitignore @@ -12,6 +12,7 @@ logs* *apicache* *pycache* +/cache /cache/* .cache .idea -- To view, visit https://gerrit.wikimedia.org/r/382670 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I750203e03d3e0edc622aba5ebffad3f8822664d8 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Huji <huji.huji(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: [bugfix] re-enable welcome.py script
by jenkins-bot (Code Review) 07 Oct '17

07 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382972 ) Change subject: [bugfix] re-enable welcome.py script ...................................................................... [bugfix] re-enable welcome.py script - ue.action() is an instance method not a property as it might suggests Bug: T176323 Change-Id: I0565a81a99c25277eaad1e88b7b8c27b5f643148 --- M scripts/welcome.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved Zoranzoki21: Looks good to me, but someone else must approve diff --git a/scripts/welcome.py b/scripts/welcome.py index ebf7faa..3baca49 100755 --- a/scripts/welcome.py +++ b/scripts/welcome.py @@ -664,8 +664,8 @@ start = globalvar.offset for ue in self.site.logevents('newusers', total=globalvar.queryLimit, start=start): - if ue.action == 'create' or ( - ue.action == 'autocreate' and globalvar.welcomeAuto): + if ue.action() == 'create' or ( + ue.action() == 'autocreate' and globalvar.welcomeAuto): yield pywikibot.User(ue.page()) def defineSign(self, force=False): -- To view, visit https://gerrit.wikimedia.org/r/382972 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0565a81a99c25277eaad1e88b7b8c27b5f643148 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <Ladsgroup(a)gmail.com> Gerrit-Reviewer: TerraCodes <terracodes(a)tools.wmflabs.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Broken: wikimedia/pywikibot-core#4341 (master - 1b19a9d)
by Travis CI 06 Oct '17

06 Oct '17

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4341 Status: Broken Duration: 1 hour, 57 minutes, and 38 seconds Commit: 1b19a9d (master) Author: jenkins-bot Message: Merge "globalusage: yield all the API results" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/cce078855a6d...1b19a9de… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/284050969?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits October 2017