Pywikibot-commits October 2017

pywikibot-commits@lists.wikimedia.org

2 participants
58 discussions

Fixed: wikimedia/pywikibot-core#4371 (master - 4df6694)
by Travis CI 28 Oct '17

28 Oct '17

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4371 Status: Fixed Duration: 19 minutes and 33 seconds Commit: 4df6694 (master) Author: jenkins-bot Message: Merge "Fix nowCommons for ko" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/9da1a2e0a844...4df6694f… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/294095342?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: Fix nowCommons for ko
by jenkins-bot (Code Review) 28 Oct '17

28 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386888 ) Change subject: Fix nowCommons for ko ...................................................................... Fix nowCommons for ko Change-Id: I7af2040dc5e5c0c0f98b765e68e365dfe9aed47d Signed-off-by: Yongmin Hong <revi(a)pobox.com> --- M scripts/nowcommons.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/nowcommons.py b/scripts/nowcommons.py index b10eba0..d3f0b40 100755 --- a/scripts/nowcommons.py +++ b/scripts/nowcommons.py @@ -122,9 +122,10 @@ u'NowCommons', ], 'ko': [ - u'NowCommons', u'공용중복', u'공용 중복', + u'NowCommons', + u'Now Commons', u'Nowcommons', ], 'nds-nl': [ -- To view, visit https://gerrit.wikimedia.org/r/386888 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7af2040dc5e5c0c0f98b765e68e365dfe9aed47d Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Revi <wiki(a)ymhong.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Revi <wiki(a)ymhong.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: pagegenerators_tests.py: Update the expected search result
by jenkins-bot (Code Review) 28 Oct '17

28 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/387008 ) Change subject: pagegenerators_tests.py: Update the expected search result ...................................................................... pagegenerators_tests.py: Update the expected search result Bug: T179232 Change-Id: I2a72a36f87b621007cb15af8986635b008bd453a --- M tests/pagegenerators_tests.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index b88770a..92b530c 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -1241,9 +1241,9 @@ # American Broadcasting Company page1 = next(gen) self.assertEqual(page1.title(), 'Q169889') - # ABC disambiguation + # Australian Broadcasting Corporation page2 = next(gen) - self.assertEqual(page2.title(), 'Q286874') + self.assertEqual(page2.title(), 'Q781365') def test_get_category_site(self): """Test the getCategory method.""" -- To view, visit https://gerrit.wikimedia.org/r/387008 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a72a36f87b621007cb15af8986635b008bd453a Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Broken: wikimedia/pywikibot-core#4370 (master - 9da1a2e)
by Travis CI 28 Oct '17

28 Oct '17

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4370 Status: Broken Duration: 1 hour, 10 minutes, and 12 seconds Commit: 9da1a2e (master) Author: jenkins-bot Message: Merge "[test] suppress deprecation warning in archivebot_tests.py" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/9213e91d9595...9da1a2e0… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/293984088?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: [test] suppress deprecation warning in archivebot_tests.py
by jenkins-bot (Code Review) 28 Oct '17

28 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385766 ) Change subject: [test] suppress deprecation warning in archivebot_tests.py ...................................................................... [test] suppress deprecation warning in archivebot_tests.py Change-Id: Ibc8dc3b65b6799dacd781cee664118ea6db4a523 --- M tests/archivebot_tests.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified Zoranzoki21: Looks good to me, but someone else must approve diff --git a/tests/archivebot_tests.py b/tests/archivebot_tests.py index 3b4971c..ac253ce 100644 --- a/tests/archivebot_tests.py +++ b/tests/archivebot_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Tests for archivebot scripts.""" # -# (C) Pywikibot team, 2016 +# (C) Pywikibot team, 2016-2017 # # Distributed under the terms of the MIT license. # @@ -13,7 +13,7 @@ import pywikibot.page from pywikibot.textlib import TimeStripper -from pywikibot.tools import StringTypes as basestring +from pywikibot.tools import suppress_warnings, StringTypes as basestring from scripts import archivebot @@ -98,7 +98,8 @@ def test_checkstr(self): """Test for extracting key and duration from shorthand notation of durations.""" self.assertEqual(archivebot.checkstr('400s'), ('s', '400')) - self.assertEqual(archivebot.checkstr('3000'), ('s', '3000')) + with suppress_warnings(): + self.assertEqual(archivebot.checkstr('3000'), ('s', '3000')) self.assertEqual(archivebot.checkstr('7d'), ('d', '7')) self.assertEqual(archivebot.checkstr('3y'), ('y', '3')) # Should pass, because the key is verified in str2time -- To view, visit https://gerrit.wikimedia.org/r/385766 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc8dc3b65b6799dacd781cee664118ea6db4a523 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

Fixed: wikimedia/pywikibot-core#4369 (master - 9213e91)
by Travis CI 25 Oct '17

25 Oct '17

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4369 Status: Fixed Duration: 2 hours, 5 minutes, and 50 seconds Commit: 9213e91 (master) Author: jenkins-bot Message: Merge "flow_tests.py: Update board page title" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/67ede3681161...9213e91d… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/292231785?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Gerrit] pywikibot/core[master]: flow_tests.py: Update board page title
by jenkins-bot (Code Review) 25 Oct '17

25 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386137 ) Change subject: flow_tests.py: Update board page title ...................................................................... flow_tests.py: Update board page title Remove `self.assertGreater(self._page.latest_revision.parent_id, 0)` because the parent_id for the current revision is 0 and it does not seem to be an stable measure. (see 227d005a4e6f) Bug: T178865 Change-Id: I8937ae8fd632b938d2ead52d03222113a6b4388d --- M tests/flow_tests.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/flow_tests.py b/tests/flow_tests.py index 4dc1a82..dfc87f8 100644 --- a/tests/flow_tests.py +++ b/tests/flow_tests.py @@ -29,7 +29,8 @@ def setUp(self): """Set up unit test.""" - self._page = Board(self.site, 'Project_talk:Sandbox/Flow test') + self._page = Board(self.site, + 'Project talk:Sandbox/Structured_Discussions_test') super(TestMediaWikiFlowSandbox, self).setUp() @@ -43,7 +44,6 @@ self._test_invoke() self._test_return_datatypes() self.assertFalse(self._page.isRedirectPage()) - self.assertGreater(self._page.latest_revision.parent_id, 0) def test_content_model(self): """Test Flow page content model.""" -- To view, visit https://gerrit.wikimedia.org/r/386137 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8937ae8fd632b938d2ead52d03222113a6b4388d Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: [bugfix] Remove overlap warning
by jenkins-bot (Code Review) 24 Oct '17

24 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385973 ) Change subject: [bugfix] Remove overlap warning ...................................................................... [bugfix] Remove overlap warning The overlap warning was introduced with T92626 but is still unclear what to do with it. The naming conflict seems already solved. See also: https://gerrit.wikimedia.org/r/#/c/196642/5/pywikibot/data/api.py@269 Bug: T92626 Bug: T171068 Bug: T178794 Change-Id: Ib81558295da67145f5b76d4100b60484f9fa2281 --- M pywikibot/data/api.py 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index f2c06dd..540648d 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -299,15 +299,6 @@ self._fetch(set(['query'])) assert 'query' in self._modules - _reused_module_names = self._action_modules & self._modules['query'] - - # The only name clash in core between actions and query submodules is - # action=tokens and actions=query&meta=tokens, and this will warn if - # any new ones appear. - if _reused_module_names > set(['tokens']): - warn('Unexpected overlap between action and query submodules: %s' - % (_reused_module_names - set(['tokens'])), UserWarning) - def _emulate_pageset(self): """Emulate the pageset module, which existed in MW 1.15-1.24.""" # pageset isnt a module in the new system, so it is emulated, with -- To view, visit https://gerrit.wikimedia.org/r/385973 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib81558295da67145f5b76d4100b60484f9fa2281 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: MarcoAurelio <maurelio(a)tools.wmflabs.org> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: dev-requirements.txt: Use httpbin<0.6.0 on Windows
by jenkins-bot (Code Review) 24 Oct '17

24 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386126 ) Change subject: dev-requirements.txt: Use httpbin<0.6.0 on Windows ...................................................................... dev-requirements.txt: Use httpbin<0.6.0 on Windows Bug: T174886 Change-Id: I48660ffb5446382526c958f953c0379a0ed723e7 --- M dev-requirements.txt 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/dev-requirements.txt b/dev-requirements.txt index 8bfa279..0e5b501 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -8,8 +8,7 @@ pytest-cov pytest-attrib pytest-httpbin -httpbin<0.6.0 ; python_version < '2.7' -httpbin!=0.6.0,!=0.6.1 ; os_name != 'posix' and python_version >= '2.7' +httpbin<0.6.0 ; os_name != 'posix' or python_version < '2.7' six -- To view, visit https://gerrit.wikimedia.org/r/386126 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48660ffb5446382526c958f953c0379a0ed723e7 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

1 0

[Gerrit] pywikibot/core[master]: [IMPR] Simplify report() method
by jenkins-bot (Code Review) 23 Oct '17

23 Oct '17

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/281604 ) Change subject: [IMPR] Simplify report() method ...................................................................... [IMPR] Simplify report() method The method never runs into the while loop but break always the loop. Return from the method instead exit the loop. Change-Id: I723d581bfd043cd20de3f9137cfbf133f3c3979b --- M scripts/checkimages.py 1 file changed, 18 insertions(+), 28 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/checkimages.py b/scripts/checkimages.py index b749c24..812ac07 100755 --- a/scripts/checkimages.py +++ b/scripts/checkimages.py @@ -591,7 +591,7 @@ """Function to make the reports easier.""" self.image_to_report = image_to_report self.newtext = newtext - self.head = head or u'' + self.head = head or '' self.notification = notification self.notification2 = notification2 @@ -603,34 +603,24 @@ notification2) self.commTalk = commTalk self.commImage = commImage or self.comment - - while True: + image_tagged = False + try: + image_tagged = self.tag_image(unver) + except pywikibot.NoPage: + pywikibot.output('The page has been deleted! Skip!') + except pywikibot.EditConflict: + pywikibot.output('Edit conflict! Skip!') + if image_tagged and self.notification: try: - resPutMex = self.tag_image(unver) - except pywikibot.NoPage: - pywikibot.output(u"The page has been deleted! Skip!") - break + self.put_mex_in_talk() except pywikibot.EditConflict: - pywikibot.output(u"Edit conflict! Skip!") - break - else: - if not resPutMex: - break - if self.notification: + pywikibot.output('Edit Conflict! Retrying...') try: self.put_mex_in_talk() - except pywikibot.EditConflict: - pywikibot.output(u"Edit Conflict! Retrying...") - try: - self.put_mex_in_talk() - except: - pywikibot.output( - u"Another error... skipping the user..") - break - else: - break - else: - break + except Exception: + pywikibot.exception() + pywikibot.output( + 'Another error... skipping the user..') def uploadBotChangeFunction(self, reportPageText, upBotArray): """Detect the user that has uploaded the file through the upload bot.""" @@ -653,7 +643,7 @@ reportPageText = reportPageObject.get() except pywikibot.NoPage: pywikibot.output(u'%s has been deleted...' % self.imageName) - return + return False # You can use this function also to find only the user that # has upload the image (FixME: Rewrite a bit this part) if put: @@ -665,7 +655,7 @@ summary=self.commImage) except pywikibot.LockedPage: pywikibot.output(u'File is locked. Skipping.') - return + return False # paginetta it's the image page object. try: if reportPageObject == self.image and self.uploader: @@ -679,7 +669,7 @@ repme = self.list_entry + "problems '''with the APIs'''" self.report_image(self.image_to_report, self.rep_page, self.com, repme) - return + return False upBots = i18n.translate(self.site, uploadBots) user = pywikibot.User(self.site, nick) luser = user.title(asUrl=True) -- To view, visit https://gerrit.wikimedia.org/r/281604 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723d581bfd043cd20de3f9137cfbf133f3c3979b Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits October 2017