Pywikibot-commits October 2017

pywikibot-commits@lists.wikimedia.org

2 participants
58 discussions

Errored: wikimedia/pywikibot-core#4356 (master - b09483b)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4356 Status: Errored Duration: 4 hours, 33 minutes, and 27 seconds Commit: b09483b (master) Author: jenkins-bot Message: Merge "[test] Replace expected_failure_if with skipIf decorator" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/d3321813be3a...b09483b6… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/290092787?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

5 years, 7 months

Errored: wikimedia/pywikibot-core#4355 (master - d332181)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #4355 Status: Errored Duration: 4 hours, 37 minutes, and 19 seconds Commit: d332181 (master) Author: jenkins-bot Message: Merge "[IMPR] Improvements for reflinks.py" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/cdec68327ef4...d3321813… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/290079642?utm_source=… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

5 years, 7 months

[Gerrit] pywikibot/core[master]: [bugfix, i18n, PEP8] Make reflinks.py work smoothly

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371973 ) Change subject: [bugfix, i18n, PEP8] Make reflinks.py work smoothly ...................................................................... [bugfix, i18n, PEP8] Make reflinks.py work smoothly - Allow running without localized stop page - Allow running without localized dead link template - Remove references to DumZiBoT as it is retired - Fix unreachable code to make limit and stop page features work - Fix double brackets when stop page edited - Fix error with requests implementation (T159645, T155509) - Fix Python 3.x and PEP8 errors Bug: T123789 Bug: T159645 Bug: T155509 Change-Id: Iae0d25523fd68ac95b351f2ac9e3cc8484277df4 --- M scripts/reflinks.py 1 file changed, 37 insertions(+), 31 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/reflinks.py b/scripts/reflinks.py index c178b0c..1d841b8 100755 --- a/scripts/reflinks.py +++ b/scripts/reflinks.py @@ -12,15 +12,12 @@ The bot checks every 20 edits a special stop page. If the page has been edited, it stops. -DumZiBoT is running that script on en: & fr: at every new dump, running it on -de: is not allowed anymore. +Warning: Running this script on German Wikipedia is not allowed anymore. As it uses it, you need to configure noreferences.py for your wiki, or it will not work. pdfinfo is needed for parsing pdf titles. - -See [[:en:User:DumZiBoT/refLinks]] for more information on the bot. &params; @@ -84,7 +81,7 @@ # should be moved to MediaWiki Pywikibot manual -stopPage = { +stop_page = { 'fr': u'Utilisateur:DumZiBoT/EditezCettePagePourMeStopper', 'da': u'Bruger:DumZiBoT/EditThisPageToStopMe', 'de': u'Benutzer:DumZiBoT/EditThisPageToStopMe', @@ -102,7 +99,6 @@ deadLinkTag = { 'fr': u'[%s] {{lien mort}}', 'da': u'[%s] {{dødt link}}', - 'de': u'', 'fa': u'[%s] {{پیوند مرده}}', 'he': u'{{קישור שבור}}', 'hu': u'[%s] {{halott link}}', @@ -215,8 +211,14 @@ def refDead(self): """Dead link, tag it with a {{dead link}}.""" - tag = i18n.translate(self.site, deadLinkTag) % self.link - return '<ref%s>%s</ref>' % (self.refname, tag) + tag = i18n.translate(self.site, deadLinkTag) + if not tag: + dead_link = self.refLink() + elif '%s' in tag: + dead_link = '<ref%s>%s</ref>' % (self.refname, tag % self.link) + else: + dead_link = '<ref%s>%s</ref>' % (self.refname, tag) + return dead_link def transform(self, ispdf=False): """Normalize the title.""" @@ -408,8 +410,6 @@ self.msg = i18n.twtranslate(self.site, 'reflinks-msg', locals()) else: self.msg = self.getOption('summary') - self.stopPage = pywikibot.Page(self.site, - i18n.translate(self.site, stopPage)) local = i18n.translate(self.site, badtitles) if local: @@ -419,12 +419,15 @@ self.titleBlackList = re.compile(bad, re.I | re.S | re.X) self.norefbot = noreferences.NoReferencesBot(None, verbose=False) self.deduplicator = DuplicateReferences() - try: - self.stopPageRevId = self.stopPage.latest_revision_id - except pywikibot.NoPage: - pywikibot.output(u'The stop page %s does not exist' - % self.stopPage.title(asLink=True)) - raise + + self.site_stop_page = i18n.translate(self.site, stop_page) + if self.site_stop_page: + self.stop_page = pywikibot.Page(self.site, self.site_stop_page) + if self.stop_page.exists(): + self.stop_page_rev_id = self.stop_page.latest_revision_id + else: + pywikibot.warning('The stop page %s does not exist' + % self.stop_page.title(asLink=True)) # Regex to grasp content-type meta HTML tag in HTML source self.META_CONTENT = re.compile(br'(?i)<meta[^>]*content\-type[^>]*>') @@ -454,7 +457,7 @@ """ pywikibot.output(u'PDF file.') fd, infile = tempfile.mkstemp() - urlobj = os.fdopen(fd, 'r+w') + urlobj = os.fdopen(fd, 'w+') urlobj.write(f.content) try: @@ -473,9 +476,9 @@ pywikibot.output(u'pdfinfo value error.') except OSError: pywikibot.output(u'pdfinfo OS error.') - except: # Ignore errors + except Exception: # Ignore errors pywikibot.output(u'PDF processing error.') - pass + pywikibot.exception() finally: urlobj.close() os.unlink(infile) @@ -583,7 +586,7 @@ new_text = new_text.replace(match.group(), repl) continue - linkedpagetext = f.content + linkedpagetext = f.raw except UnicodeError: # example : http://www.adminet.com/jo/20010615¦/ECOC0100037D.html # in [[fr:Cyanure]] @@ -709,12 +712,13 @@ new_text = self.norefbot.addReferences(new_text) new_text = self.deduplicator.process(new_text) + old_text = page.text - self.userPut(page, page.text, new_text, summary=self.msg, + self.userPut(page, old_text, new_text, summary=self.msg, ignore_save_related_errors=True, ignore_server_errors=True) - if new_text == page.text: + if new_text == old_text: continue else: editedpages += 1 @@ -723,15 +727,17 @@ pywikibot.output('Edited %s pages, stopping.' % self.getOption('limit')) return - if editedpages % 20 == 0: - pywikibot.output(color_format( - '{lightgreen}Checking stop page...{default}')) - actualRev = self.stopPage.latest_revision_id - if actualRev != self.stopPageRevId: - pywikibot.output( - u'[[%s]] has been edited : Someone wants us to stop.' - % self.stopPage) - return + if self.site_stop_page and editedpages % 20 == 0: + self.stop_page = pywikibot.Page(self.site, self.site_stop_page) + if self.stop_page.exists(): + pywikibot.output(color_format( + '{lightgreen}Checking stop page...{default}')) + actual_rev = self.stop_page.latest_revision_id + if actual_rev != self.stop_page_rev_id: + pywikibot.output( + '%s has been edited : Someone wants us to stop.' + % self.stop_page.title(asLink=True)) + return def main(*args): -- To view, visit https://gerrit.wikimedia.org/r/371973 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae0d25523fd68ac95b351f2ac9e3cc8484277df4 Gerrit-PatchSet: 10 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: [test] Replace expected_failure_if with skipIf decorator

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385024 ) Change subject: [test] Replace expected_failure_if with skipIf decorator ...................................................................... [test] Replace expected_failure_if with skipIf decorator unittest's expected failure decorators are handy when a bug was identified in the code but wasn't fixed yet in the current release. The different behavior of py2 and py3 related to string elements which aren't string constants cannot be solved because it is an upstream problem and part of the release difference issue. Therefore we shouldn't use that expected failure reminder but just skip the test for py3. Bug: T178528 Change-Id: I40fce5d7a4605fcc1b2cdd7b811c31eef53d4a2c --- M tests/tools_tests.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved Zoranzoki21: Looks good to me, but someone else must approve diff --git a/tests/tools_tests.py b/tests/tools_tests.py index be7acc0..791ab57 100644 --- a/tests/tools_tests.py +++ b/tests/tools_tests.py @@ -2,7 +2,7 @@ # -*- coding: utf-8 -*- """Test tools package alone which don't fit into other tests.""" # -# (C) Pywikibot team, 2016 +# (C) Pywikibot team, 2016-2017 # # Distributed under the terms of the MIT license. from __future__ import absolute_import, unicode_literals @@ -29,7 +29,7 @@ unittest, require_modules, DeprecationTestCase, TestCase, MetaTestCaseClass ) -from tests.utils import expected_failure_if, add_metaclass +from tests.utils import add_metaclass class ContextManagerWrapperTestCase(TestCase): @@ -573,10 +573,10 @@ deduper = tools.filter_unique(self.strs, container=deduped, key=hash) self._test_dedup_str(deduped, deduper, hash) - @expected_failure_if(not tools.PY2) + @unittest.skipIf(not tools.PY2, + 'str in Py3 behave like objects and id as key fails') def test_str_id(self): - """Test str using id as key fails on Python 3.""" - # str in Python 3 behave like objects. + """Test str using id as key.""" deduped = set() deduper = tools.filter_unique(self.strs, container=deduped, key=id) self._test_dedup_str(deduped, deduper, id) -- To view, visit https://gerrit.wikimedia.org/r/385024 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40fce5d7a4605fcc1b2cdd7b811c31eef53d4a2c Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: [IMPR] Improvements for reflinks.py

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/283407 ) Change subject: [IMPR] Improvements for reflinks.py ...................................................................... [IMPR] Improvements for reflinks.py - raise NotImplementedError if 404-links.txt isn't found. The old message might be overseen when exception raises. - simplify arg parsing - ask for the filename or start article if an empty xml/xmlstart option is given Change-Id: Ie1b2044ff25b7e46e8e2b2e38cb1fd3df1816534 --- M scripts/reflinks.py 1 file changed, 20 insertions(+), 26 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved Zoranzoki21: Looks good to me, but someone else must approve diff --git a/scripts/reflinks.py b/scripts/reflinks.py index fd3352f..26f7b95 100755 --- a/scripts/reflinks.py +++ b/scripts/reflinks.py @@ -38,7 +38,7 @@ one from i18n/reflinks.py """ # (C) Nicolas Dumazet (NicDumZ), 2008 -# (C) Pywikibot team, 2008-2016 +# (C) Pywikibot team, 2008-2017 # # Distributed under the terms of the MIT license. # @@ -487,11 +487,11 @@ try: deadLinks = codecs.open(listof404pages, 'r', 'latin_1').read() except IOError: - pywikibot.output( - 'You need to download ' - 'http://www.twoevils.org/files/wikipedia/404-links.txt.gz ' - 'and to ungzip it in the same directory') - raise + raise NotImplementedError( + '404-links.txt is required for reflinks.py\n' + 'You need to download\n' + 'http://www.twoevils.org/files/wikipedia/404-links.txt.gz\n' + 'and to unzip it in the same directory') editedpages = 0 for page in self.generator: @@ -755,26 +755,20 @@ genFactory = pagegenerators.GeneratorFactory() for arg in local_args: - if arg.startswith('-summary:'): - options['summary'] = arg[9:] - elif arg == '-always': - options['always'] = True - elif arg == '-ignorepdf': - options['ignorepdf'] = True - elif arg.startswith('-limit:'): - options['limit'] = int(arg[7:]) - elif arg.startswith('-xmlstart'): - if len(arg) == 9: - xmlStart = pywikibot.input( - u'Please enter the dumped article to start with:') - else: - xmlStart = arg[10:] - elif arg.startswith('-xml'): - if len(arg) == 4: - xmlFilename = pywikibot.input( - u'Please enter the XML dump\'s filename:') - else: - xmlFilename = arg[5:] + arg, sep, value = arg.partition(':') + option = arg.partition('-')[2] + if option == 'summary': + options[option] = value + elif option in ('always', 'ignorepdf'): + options[option] = True + elif option == 'limit': + options[option] = int(value) + elif option == 'xmlstart': + xmlStart = value or pywikibot.input( + 'Please enter the dumped article to start with:') + elif option == 'xml': + xmlFilename = value or pywikibot.input( + "Please enter the XML dump's filename:") else: genFactory.handleArg(arg) -- To view, visit https://gerrit.wikimedia.org/r/283407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1b2044ff25b7e46e8e2b2e38cb1fd3df1816534 Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: [bugfix] re-enable sep parameter for Timestamp.isoformat

by Mpaa (Code Review)

Mpaa has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/381979 ) Change subject: [bugfix] re-enable sep parameter for Timestamp.isoformat ...................................................................... [bugfix] re-enable sep parameter for Timestamp.isoformat - Timestamp.isoformat was redefined but does not support "sep" parameter anymore which is an optional parameter of datetime.isoformat() objects which is the superclass of Timestamp. Re-enable this parameter to be compatible with the datetime object again (and with compat btw.) - Also allow a "sep" parameter in fromISOformat method to convert it back - Tests added Bug: T177285 Change-Id: Ie5209267188173c5702ba11378d55e25e9f8a193 --- M pywikibot/__init__.py M tests/timestamp_tests.py 2 files changed, 59 insertions(+), 7 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index 348b596..6404b19 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -68,6 +68,7 @@ from pywikibot.site import BaseSite from pywikibot.tools import ( # __ to avoid conflict with ModuleDeprecationWrapper._deprecated + classproperty, deprecated as __deprecated, deprecate_arg as _deprecate_arg, normalize_username, @@ -156,21 +157,45 @@ """ mediawikiTSFormat = "%Y%m%d%H%M%S" - ISO8601Format = "%Y-%m-%dT%H:%M:%SZ" _ISO8601Format_new = '{0:+05d}-{1:02d}-{2:02d}T{3:02d}:{4:02d}:{5:02d}Z' def clone(self): """Clone this instance.""" return self.replace(microsecond=self.microsecond) + @classproperty + def ISO8601Format(cls): # flake8: disable=N805 + """ISO8601 format string class property for compatibility purpose.""" + return cls._ISO8601Format() + @classmethod - def fromISOformat(cls, ts): - """Convert an ISO 8601 timestamp to a Timestamp object.""" + def _ISO8601Format(cls, sep='T'): + """ISO8601 format string. + + @param sep: one-character separator, placed between the date and time + @type sep: str + @return: ISO8601 format string + @rtype: str + """ + assert(len(sep) == 1) + return '%Y-%m-%d{0}%H:%M:%SZ'.format(sep) + + @classmethod + def fromISOformat(cls, ts, sep='T'): + """Convert an ISO 8601 timestamp to a Timestamp object. + + @param ts: ISO 8601 timestamp or a Timestamp object already + @type ts: str ot Timestamp + @param sep: one-character separator, placed between the date and time + @type sep: str + @return: Timestamp object + @rtype: Timestamp + """ # If inadvertantly passed a Timestamp object, use replace() # to create a clone. if isinstance(ts, cls): return ts.clone() - return cls.strptime(ts, cls.ISO8601Format) + return cls.strptime(ts, cls._ISO8601Format(sep)) @classmethod def fromtimestampformat(cls, ts): @@ -181,7 +206,7 @@ return ts.clone() return cls.strptime(ts, cls.mediawikiTSFormat) - def isoformat(self): + def isoformat(self, sep='T'): """ Convert object to an ISO 8601 timestamp accepted by MediaWiki. @@ -189,7 +214,7 @@ with a 'Z' unless a timezone is included, which causes MediaWiki ~1.19 and earlier to fail. """ - return self.strftime(self.ISO8601Format) + return self.strftime(self._ISO8601Format(sep)) toISOformat = redirect_func(isoformat, old_name='toISOformat', class_name='Timestamp') diff --git a/tests/timestamp_tests.py b/tests/timestamp_tests.py index 2431164..a466352 100644 --- a/tests/timestamp_tests.py +++ b/tests/timestamp_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Tests for the Timestamp class.""" # -# (C) Pywikibot team, 2014-2016 +# (C) Pywikibot team, 2014-2017 # # Distributed under the terms of the MIT license. # @@ -9,6 +9,7 @@ import calendar import datetime +import re from pywikibot import Timestamp @@ -40,6 +41,7 @@ def test_iso_format(self): """Test conversion from and to ISO format.""" + SEP = 'T' t1 = Timestamp.utcnow() ts1 = t1.isoformat() t2 = Timestamp.fromISOformat(ts1) @@ -49,6 +51,31 @@ t1 = t1.replace(microsecond=0) self.assertEqual(t1, t2) self.assertEqual(ts1, ts2) + date, sep, time = ts1.partition(SEP) + time = time.rstrip('Z') + self.assertEqual(date, str(t1.date())) + self.assertEqual(time, str(t1.time())) + + def test_iso_format_with_sep(self): + """Test conversion from and to ISO format with separator.""" + SEP = '*' + t1 = Timestamp.utcnow().replace(microsecond=0) + ts1 = t1.isoformat(sep=SEP) + t2 = Timestamp.fromISOformat(ts1, sep=SEP) + ts2 = t2.isoformat(sep=SEP) + self.assertEqual(t1, t2) + self.assertEqual(t1, t2) + self.assertEqual(ts1, ts2) + date, sep, time = ts1.partition(SEP) + time = time.rstrip('Z') + self.assertEqual(date, str(t1.date())) + self.assertEqual(time, str(t1.time())) + + def test_iso_format_property(self): + """Test iso format properties.""" + self.assertEqual(Timestamp.ISO8601Format, Timestamp._ISO8601Format()) + self.assertEqual(re.sub('[\-\:TZ]', '', Timestamp.ISO8601Format), + Timestamp.mediawikiTSFormat) def test_mediawiki_format(self): """Test conversion from and to timestamp format.""" -- To view, visit https://gerrit.wikimedia.org/r/381979 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5209267188173c5702ba11378d55e25e9f8a193 Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm(a)member.fsf.org> Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: category_redirect.py: Changed name of category for srwiki

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383932 ) Change subject: category_redirect.py: Changed name of category for srwiki ...................................................................... category_redirect.py: Changed name of category for srwiki Change-Id: Ib711fde8eaba66f071d9db9bbf46bb779ac14202 --- M scripts/category_redirect.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dvorapa: Looks good to me, but someone else must approve Framawiki: Looks good to me, but someone else must approve jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/category_redirect.py b/scripts/category_redirect.py index 6af1688..64cbbd1 100755 --- a/scripts/category_redirect.py +++ b/scripts/category_redirect.py @@ -90,7 +90,7 @@ 'sco': "Category:Wikipaedia soft redirectit categories", 'simple': "Category:Category redirects", 'sh': u"Kategorija:Preusmjerene kategorije Wikipedije", - 'sr': 'Категорија:Wikipedia soft redirected categories', + 'sr': 'Категорија:Википедијине меко преусмерене категорије', 'vi': u"Thể loại:Thể loại đổi hướng", 'zh': u"Category:已重定向的分类", 'ro': 'Categorie:Categorii de redirecționare', -- To view, visit https://gerrit.wikimedia.org/r/383932 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib711fde8eaba66f071d9db9bbf46bb779ac14202 Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Hashar <hashar(a)free.fr> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Maven-release-user <maven-release-user(a)wikimedia.org> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: [bugfix] Prevent nested error handing

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384324 ) Change subject: [bugfix] Prevent nested error handing ...................................................................... [bugfix] Prevent nested error handing Bug: T176297 Change-Id: I5d5b2be952946bc776249d87e892fd3c3fbb79d9 --- M tests/site_tests.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_tests.py b/tests/site_tests.py index 3adc9ee..1b45692 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -1487,11 +1487,12 @@ get_redirects=True, where='title'): self.assertIsInstance(hit, pywikibot.Page) self.assertEqual(hit.namespace(), 0) - try: - self.assertIn('wiki', hit.title().lower()) - except AssertionError: - self.assertTrue(any('wiki' in r.title().lower() for r in - hit.getReferences(redirectsOnly=True))) + if 'wiki' not in hit.title().lower(): + self.assertTrue( + any('wiki' in r.title().lower() + for r in hit.getReferences(redirectsOnly=True)), + "'wiki' neither found in '{0}'.lower() " + 'nor in its redirects'.format(hit.title())) except pywikibot.data.api.APIError as e: if e.code in ('search-title-disabled', 'gsrsearch-title-disabled'): raise unittest.SkipTest( -- To view, visit https://gerrit.wikimedia.org/r/384324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d5b2be952946bc776249d87e892fd3c3fbb79d9 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/i18n[master]: Test commit to test automatic submodule update

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384250 ) Change subject: Test commit to test automatic submodule update ...................................................................... Test commit to test automatic submodule update Bug: T178067 Change-Id: If1e7e852a05ffcce70b21d95280005e43f9db8ac --- M Gruntfile.js 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified diff --git a/Gruntfile.js b/Gruntfile.js index 23ed8ac..8b511d2 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,5 +1,6 @@ /*! * Grunt file + * https://gruntjs.com/api/grunt.file */ /*jshint node:true */ -- To view, visit https://gerrit.wikimedia.org/r/384250 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1e7e852a05ffcce70b21d95280005e43f9db8ac Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Owner: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

[Gerrit] pywikibot/core[master]: Fix url for .gitmodules

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384210 ) Change subject: Fix url for .gitmodules ...................................................................... Fix url for .gitmodules Bug: T178067 Change-Id: Ic046706c66f5b41b9e31a894c026dcf328ca39dd --- M .gitmodules 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified Xqt: Looks good to me, but someone else must approve diff --git a/.gitmodules b/.gitmodules index 2c87632..b58ffc3 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,5 +1,5 @@ [submodule "i18n"] path = scripts/i18n - url = https://gerrit.wikimedia.org/r/p/pywikibot/i18n.git + url = https://gerrit.wikimedia.org/r/pywikibot/i18n branch = master ignore = all -- To view, visit https://gerrit.wikimedia.org/r/384210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic046706c66f5b41b9e31a894c026dcf328ca39dd Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall410(a)yahoo.com> Gerrit-Reviewer: Chad <chadh(a)wikimedia.org> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Hashar <hashar(a)free.fr> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm(a)member.fsf.org> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Paladox <thomasmulhall410(a)yahoo.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

5 years, 7 months

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits October 2017