*Matt*:
Follow-up about Getting Started extension Reviewed ToC stuff, everything is merged except for Erik's last patch. We can start testing on beta. Doing a little more work, and merging ToC for release this afternoon.
*Erik*:
Reviewing ToC, yesterday and this morning. Fixed Office Wiki history pages that were throwing fatal errors (T78103). This happened because the talk page conversion script created the Flow workflow but didn't create a header. This is a bug from early in the conversion process that's been fixed, but we had to go back and fix the ones that happened on Office. Reviewed some of Matthias' patches. Today: picking up Sprint O tickets.
Erik will be the release readiness review ranger this week. S says that some of the tests have been fataling for a while -- he has a writeup of Jenkins tips that the team says would be helpful.
*Matthias*:
Emailed Chad and Nik about new search Sent a patch to Elastica. Followed up with Anton on the Parsoid unit tests. Tomorrow: picking up new Sprint O stuff.
On Tue, Jan 13, 2015 at 11:42 AM, Danny Horn dhorn@wikimedia.org wrote:
Erik will be the release readiness review ranger this week. S says that some of the tests have been fataling for a while -- he has a writeup of Jenkins tips that the team says would be helpful.
I fixed the no-javascript test, it was a minor update to the locator for the Topic. https://gerrit.wikimedia.org/r/#/c/184732/1
Before fixing the lock-unlock test, I'd like to have some idea of whether Locking a topic should require a reason: https://phabricator.wikimedia.org/T86579. I'm content to let those tests fail until we know. -Chris
Chris, where do you see Lock not requiring a reason?
Here's a screenshot from https://www.mediawiki.org/wiki/Talk:Sandbox -- choosing Lock in the action menu gives you a box to write the reason. The "Lock topic" button is grayed out until you type a reason.
On Tue, Jan 13, 2015 at 12:29 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, Jan 13, 2015 at 11:42 AM, Danny Horn dhorn@wikimedia.org wrote:
Erik will be the release readiness review ranger this week. S says that some of the tests have been fataling for a while -- he has a writeup of Jenkins tips that the team says would be helpful.
I fixed the no-javascript test, it was a minor update to the locator for the Topic. https://gerrit.wikimedia.org/r/#/c/184732/1
Before fixing the lock-unlock test, I'd like to have some idea of whether Locking a topic should require a reason: https://phabricator.wikimedia.org/T86579. I'm content to let those tests fail until we know. -Chris
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
It's probably phrased badly. I'm using the page in beta labs at http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA
As a logged in user with privileges, click any of Hide/Delete/Suppress and see a lightbox modal dialog. But the UI for Lock is completely different than Hide/Delete/Suppress and (at least to me) looks contributing to the thread.
I should have looked more closely, sorry for the confusion.
On Tue, Jan 13, 2015 at 3:37 PM, Danny Horn dhorn@wikimedia.org wrote:
Chris, where do you see Lock not requiring a reason?
Here's a screenshot from https://www.mediawiki.org/wiki/Talk:Sandbox -- choosing Lock in the action menu gives you a box to write the reason. The "Lock topic" button is grayed out until you type a reason.
On Tue, Jan 13, 2015 at 12:29 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, Jan 13, 2015 at 11:42 AM, Danny Horn dhorn@wikimedia.org wrote:
Erik will be the release readiness review ranger this week. S says that some of the tests have been fataling for a while -- he has a writeup of Jenkins tips that the team says would be helpful.
I fixed the no-javascript test, it was a minor update to the locator for the Topic. https://gerrit.wikimedia.org/r/#/c/184732/1
Before fixing the lock-unlock test, I'd like to have some idea of whether Locking a topic should require a reason: https://phabricator.wikimedia.org/T86579. I'm content to let those tests fail until we know. -Chris
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
On Tue, Jan 13, 2015 at 3:23 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
It's probably phrased badly. I'm using the page in beta labs at http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA
As a logged in user with privileges, click any of Hide/Delete/Suppress and see a lightbox modal dialog. But the UI for Lock is completely different than Hide/Delete/Suppress and (at least to me) looks contributing to the thread.
It's inline in the topic titlebar because it's showing what the titlebar will look like, same as Summarize.
But I found four bugs with it, for now I put them all in a comment https://phabricator.wikimedia.org/T86579 (sorry):
- When you unlock a topic the form where you give your reason to unlock is *also* displayed inline in the titlebar. That doesn't make sense, because the reason to lock and your reason to unlock will both go away. - A topic can have a summary and a lock reason, but while you're entering the lock reason the summary is hidden. - Fixing T86377: No placeholder text in Flow lock topic textarea https://phabricator.wikimedia.org/T86377 would help a bit. - When you lock a topic and click [Preview] you get a red errorbox containing "The content parameter must be set" because the API call to flow-parsoid-utils to convert from:wikitext to:html isn't provided the content to convert. - I don't think the lock reason is wikitext! It's not like summarize
On 01/13/2015 08:50 PM, S Page wrote:
But I found four bugs with it, for now I put them all in a comment https://phabricator.wikimedia.org/T86579 (sorry):
Good digging. I broke them out into separate bugs.
Matt
Thanks, and my apologies for the poor quality of the first report. :) -Chris
On Wed, Jan 14, 2015 at 9:51 PM, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 01/13/2015 08:50 PM, S Page wrote:
But I found four bugs with it, for now I put them all in a comment https://phabricator.wikimedia.org/T86579 (sorry):
Good digging. I broke them out into separate bugs.
Matt
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee
