*Erik*:
Found a couple bugs with LQT --- topics were being shown with time title was edited, not created. Today -- more LQT action. Figuring out the timestamp issues, and testing the script. Nick/Andrew have been talking on IRC about a concern about deleted LQT posts not showing up in the history. There's a question about whether leaving LQT pages still existing on the wiki, we're going to see every post show up twice in people's contributions list.
*Shahyar*:
Got a few fixes in for ToC bugs. Concerned about the approach to what happens when you jump to a later spot on the page. There are still some problems with the basic functionality of loading the topic list, and scrolling to the right place on the page. Shahyar will reach out to Matt today to discuss current roadblocks.
*Matt*:
Yesterday: Reviewed ToC code, made small fix to collapse patch. Started reviewing Matthias' event-logging patch (L1). Suggested an alternative approach that would deal with some performance issues. Today: work on FlowMenu event-logging (L3), shouldn't be miuch rebasing to make it consistent with L1. After that, back to code review on ToC.
*Bug review*:
73477 -- Amir flagged this, it's an internationalization problem we should fix. 73455 -- Antoine flagged. Matt isn't sure what Antoine means by MediaWiki skin. 73451 -- QA browser tests for collapse are failing. S will review, and get back to Chris. 73447 -- Nick -- should be fixed with K2, which just got bounced back from product review to Blocked with questions. 73443 -- fatal exceptions for subpages in the Topic namespace.
Matthias is recovering from jet lag. :)
73451 -- QA browser tests for collapse are failing. S will review, and get back to Chris.
This patch removes the test completely, which I think is a Good Thing:
https://gerrit.wikimedia.org/r/#/c/166727/
When the ToC change is in place, let us write a sane test for that instead.
On Tue, Nov 18, 2014 at 2:23 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
73451 -- QA browser tests for collapse are failing. S will review, and get back to Chris.
This patch removes the test completely, which I think is a Good Thing:
Sure, but we won't remove collapse functionality until we have the TOC feature ready to replace it, which could take some time. Meanwhile I +2d https://gerrit.wikimedia.org/r/#/c/164720/ which makes collapse.feature test pass (for me). If that doesn't help then yes let's just split out removing collapse tests from gerrit 166727 and merge that.
BTW all browsertests-Flow-en.wikipedia.beta.wmflabs are green right now.