On Thu, Nov 20, 2014 at 12:08 PM, Shahyar Ghobadpour < sghobadpour@wikimedia.org> wrote:
I missed standup, my apologies. TOC is up and running on flow-tests. Can be product reviewed, look for any browser bugs. Non show-stoppers for now:
- I've noticed a couple of minor issues in Firefox, but not in Chrome, so
I'm trying to isolate those. Need to test other browsers as well.
- I need to implement the new loader animation (ellipsis).
It's bounce[123] in showLoadingIndicator() in modules/source/ext.cx.source.js. We and ContentTranslation (git blame says Santhosh Thottingal worked on it) should propose this for MW core, https://trello.com/c/2u8W6qn8
- Gotta remove the "no older topics" message from TOC.
I guess so. When we have a consistent loading animation at the bottom of the TOC I think it'll be obvious when you've reached the end. (We don't have a spec for the no-JS TOC.)
Danny and I noticed that the TOC doesn't always load the rest of the titles. It got stuck for me at 60 items. (The numbering in the TOC is very helpful, I assume it's temporary along with loading 10 at a time instead of 100.)
- Need to add "X" to close TOC (I only noticed this in the requirements
now -- it does not exist on any of the design mockups except for ONE).
Which mockup? I haven't missed it. The Echo flyout doesn't have a close "X". Danny Pau what do you think?
- Code needs to be split up, but this doesn't prevent product reviewing.