I missed standup, my apologies. TOC is up and running on flow-tests. Can be product reviewed, look for any browser bugs. Non show-stoppers for now: - I've noticed a couple of minor issues in Firefox, but not in Chrome, so I'm trying to isolate those. Need to test other browsers as well. - I need to implement the new loader animation (ellipsis). - Gotta remove the "no older topics" message from TOC. - Need to add "X" to close TOC (I only noticed this in the requirements now -- it does not exist on any of the design mockups except for ONE). - Code needs to be split up, but this doesn't prevent product reviewing.
--Shahyar
On Thu, Nov 20, 2014 at 1:49 PM, Danny Horn dhorn@wikimedia.org wrote:
*Matt*:
Figured out why manual LQT tests were failing, reviewed a related patch by Erik Found an issue importing a really big board from Mwiki -- crashing. Updated the header patch, probably needs a couple small additional things. Needs to talk to Erik about something found in the tests. Started reviewing one of the ToC patches. Today: Finishing LQT patch, reviewing ToC.
*Matthias*:
Worked on event-logging (L1), in code review. Now back to search (L108). Looking at CirrusSearch to determine which parts need to be adapted for Flow data. Part of this work is figuring out the Analyzers for highlighting -- when that's done, it'll inform the spike about putting a special class around the highlighted search terms in the threads.
*Erik*:
Erik reviewed Andrew's patches, made a couple suggestions. Also reviewed Matt's LQT header patch, made a suggestion. Nick had noticed the edited timestamps being wrong -- made a patch for that. Now working on script to move existing wiki talk pages to Talk:Foo/archive. (L110) Today: Finish script for moving wiki talk pages.
EE mailing list EE@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ee