Hey,
PHPUnits assertTag function, which is used 32 times in Wikibase.git, will be deprecated in PHPUnit 4.2. https://github.com/sebastianbergmann/phpunit/issues/1292
Cheers
-- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3
On Sun, Aug 17, 2014 at 6:23 PM, Jeroen De Dauw jeroendedauw@gmail.com wrote:
Hey,
PHPUnits assertTag function, which is used 32 times in Wikibase.git, will be deprecated in PHPUnit 4.2. https://github.com/sebastianbergmann/phpunit/issues/1292
https://bugzilla.wikimedia.org/show_bug.cgi?id=67122
Cheers, Katie
Cheers
-- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3
Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
Let's say I'm testing a method that returns a small HTML snippet. In your opinion, is it ok if I replace assertTag with one or more 1-line regular expressions? (Focus on readability, each regular expression should only test one aspect.)
Best Thiemo
I'll say it would be far better to implement your own "assertTag" to avoid rewrite the same unreadable regex pattern over and over. Or to look if the testing framework provides a replacement or a prefered way to replace those.
Le lundi 18 août 2014, Thiemo Mättig thiemo.maettig@wikimedia.de a écrit :
Let's say I'm testing a method that returns a small HTML snippet. In your opinion, is it ok if I replace assertTag with one or more 1-line regular expressions? (Focus on readability, each regular expression should only test one aspect.)
Best Thiemo
wikidata-tech@lists.wikimedia.org