Wikidata-tech

wikidata-tech@lists.wikimedia.org

1 participants
622 discussions

External Json is not so consistent
by Fredo Erxleben 18 Jun '14

18 Jun '14

Hello, I found, when looking at the external Json, that it uses different notations for pretty much the same thing. If we talk about item ids on the document level the Json hast the form: "id":"Q1", "type":"item" Once you talk about item ids on the level of a snaks value it is: "entity-type":"item", "numeric-id":"1" Is there any deeper meaning that prevents, using only one of these forms? (Also notice, that "entity-type" is redundant, since it is already given by a snaks "datatype":"wikibase-item") Sincerly, Fredo Erxleben

4 7

TravisCI integration with Gerrit
by Jeroen De Dauw 14 Jun '14

14 Jun '14

Hey Steffen and Andy, Continuing what I started on Twitter here, as some more characters might be helpful :) It seems that both our projects (FLOW3 and Wikidata) are in a similar situation. We are using Gerrit as CR tool, and TravisCI to run our tests. And we both want to have Travis run tests for all patchsets submitted to Gerrit, and then +1 or -1 on verified based on the build passing or failing. To what extend have you gotten such a thing to work on your project? Is there code available anywhere? If both projects can use the same code for this, I'd be happy to contribute to what you already have. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 --

2 2

where did puppetd go on labs?
by Katie Filbert 10 Jun '14

10 Jun '14

If you use puppet on a labs instance and are wondering where puppetd went... puppet has been upgraded on labs to puppet 3. If you use puppet on a labs instance, instead of doing "puppetd -tv" now it is "puppet agent -tv". Cheers, Katie -- Katie Filbert Wikidata Developer Wikimedia Germany e.V. | Tempelhofer Ufer 23-24, 10963 Berlin Phone (030) 219 158 26-0 http://wikimedia.de Wikimedia Germany - Society for the Promotion of free knowledge eV Entered in the register of Amtsgericht Berlin-Charlottenburg under the number 23 855 as recognized as charitable by the Inland Revenue for corporations I Berlin, tax number 27/681/51985.

1 0

Badges user interface
by Bene* 07 Jun '14

07 Jun '14

Hi developers, I am currently working on the user interface on Wikibase's repository to edit badges. There exist several mockups [1] - especially [2] - but I got stuck while trying to implement them actually. The resource system of Wikibase is quite confusing and I am not sure if the way I tried it [3] does really make sense and is the right attempt. Here are some questions which came in my mind until now but I am sure there will be more questions later. However, I would be glad if you can help me already now to show me the right way. First, I am not sure if the current attempt to add the HTML for the ui into the sitelink's row is useful. I saw that most of those popup bubble boxes are implemented as jquery widgets and added to the end of the document. However, this might become a bit too hard because while the options for a statement's rank are always the same but the badges are different for each sitelink. So perhaps it is better how I implemented it right now with the HTML hidden by default and positioned with position:absolute. Another question is if we should implement the toggling of the bubble with plain CSS or by the use of javascript. In my opinion it is saner to do this with javascript and will create a better look and feel. However, I have no clue where the toggling logic should be put, so if this is a widget or comes to the edit tool. One issue concerns the arrow/triangle of the box pointing to the star. Should this triangle created by a background image or by pure CSS? All those questions are perhaps only the beginning but I'm sure we will have a great badges edit tool once this is finished. Best regards, Bene* [1] https://commons.wikimedia.org/wiki/Category:Wikidata_storyboards_-_Badges [2] https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface_%28… [3] https://gerrit.wikimedia.org/r/#/c/124391/

1 0

Fingerprint method signature change
by Jeroen De Dauw 07 Jun '14

07 Jun '14

Hey, The upcoming 1.0 version of DataModel makes a breaking change to the setLabel, setDescription and setAliasGroup methods of Fingerprint [0]. This means that for now it is best to refrain from using these convenience methods, as it makes migration to 1.0 harder. [0] https://github.com/wmde/WikibaseDataModel/blob/master/RELEASE-NOTES.md Cheers -- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3

1 0

Constructing Entities from their serialization
by Jeroen De Dauw 06 Jun '14

06 Jun '14

Hey, Constructing entities from their serialization in tests has long been discouraged. A few weeks back we removed support for this on the master branch of DataModel. In going though the remaining occurrences, I find myself surprised that some got introduced as little as two weeks ago, and merged in by a member of the Wikidata team. What to not do: $item = new Item( array( .... ) ); What to do instead (as has been done in most places for quite some time): $item = Item::newEmpty(); $item->setStuff(); Cheers -- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3

3 4

Keeping the tests simple
by Jeroen De Dauw 06 Jun '14

06 Jun '14

Hey, In trying to remove deprecated method usage, I've found that quite a few tests in Wikibase.git are really complicated. Mostly this seems to be caused by trying to stuff tests for structurally very different behaviours in the same test method and data provider. There is no need to do this at all. The need for a control structure in a test method is very rare, and should be carefully considered. There is a lot of good material on the topic, though if you cannot find the time to look into that, just keep that simple guideline in mind: no control structures. Please keep the tests (and production code) simple! Cheers -- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3

1 1

Planned changes to the Entity hierarchy
by Jeroen De Dauw 02 Jun '14

02 Jun '14

Hey, This email serves to outline planned changed to the Entity class hierarchy so they can be held into account for development. This has no immediate impact on user facing functionality. Right now we have an Entity class that holds an EntityId, a Fingerprint and a list of Claim. Item derives from Entity and adds a list of SiteLink, as well as changing the list of Claim to a list of Statement. Property also derives from Entity and adds only a property type field. In the future we will have more types of entities, such as a QueryEntity which holds a query description and entities for Wikimedia Commons. The problem is that these different types of entities are made up of different things, and the intersection between all of them is only that they have an id. Hence the code sharing by inheritance approach we currently have is definitely a mistake. The thing we are aiming for is to use more specific interfaces and the things that make up entities. Example: You have a list of items and properties, and you want to store their terms into a database table for lookup purposes. Rather than having the "term store" take an Entity and so increase the assumption that all entities have terms, only require what is strictly needed. In this case an EntityId and a Fingerprint (which contains the terms). $termStore->insertTermsForEntity( Entity $entity ) $termStore->insertTermsForEntity( EntityId $id, Fingerprint $fingerprint ) Any type hint against Entity suggests an assumption we already know will not hold. Hence avoid parameters and fields of type Entity. Mirroring the Entity class hierarchy, such as EntityDiff and ItemDiff, is another thing to avoid. New occurrences of any of these should not be added, so please -1 any commits that do so. To avoid confusion: it is perfectly fine to have a parameter or field of a concrete entity type, such as Item or Property. Cheers -- Jeroen De Dauw - http://www.bn2vs.com Software craftsmanship advocate Evil software architect at Wikimedia Germany ~=[,,_,,]:3

1 0

Requested languages and Wikidata
by Gerard Meijssen 23 May '14

23 May '14

Hoi, The language policy has it that any eligible language may be enabled for Wikidata. Several of the languages in the Incubator are functional in Wikidata already others are not. This list shows all the requested languages and it shows an indicator when the language can be used on Wikidata (only for eligible languages). Please have a look and let me know when you have any comments. The idea is that we will ask in a week for languages that are eligible to be enabled. Thanks, GerardM https://docs.google.com/spreadsheets/d/171gBmi4nCeVHkTt6xPWZsmUg9mkhlpZ-1zW…

1 0

Discussion log: Fingerprint class
by Daniel Kinzler 22 May '14

22 May '14

Discussion about Wikibase DataModel, especially the Fingerprint class (Jeroen, Thiemo, Daniel): * add convenience methods for setting labels, etc * add copy() for deep cloning * getters returning mutable objects should say whether they return a copy * be careful to not overuse list objects * We still need AliasGroup, but AliasGroupList can probably be replaced by a plain array. I hope I got this all right. -- daniel -- Daniel Kinzler Senior Software Developer Wikimedia Deutschland Gesellschaft zur Förderung Freien Wissens e.V.

1 0

← Newer
1
...
43
44
45
46
47
48
49
...
63
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Wikidata-tech