Hi everyone,
On the recent hackathon in Vienna we talked about the large number of changes still open and how to get the flow back. We currently have over 300 open changes going back to 2014 ( https://gerrit.wikimedia.org/r/#/q/status:open+project:pywikibot/core ). A change is in Gerrit because the developer wants code review to get it merged. Code review might not be a lot of fun and this is made worse by this huge backlog. A lot of the changes have issues preventing this: * Merge conflict, needs to be rebased * Not verified, tests fail * Code review -1, -2 My proposal is to abandon the changes we're not going to work on anyway and focus our attention on the changes we do want to get merged. I understand that some changes in which people invested a lot of time and effort will get abandoned, but I think the benefit of getting the code review process back on track is higher. Abandoned changes are not gone, we can always open them again.
I ask everyone who has (a lot of) old open changes to have a look at them and make the decision: Pick it up or abandon. If the change is linked to a phabricator task, it would be nice to update the task too.
Thank you,
Maarten
I support this idea.
On Thu, May 25, 2017 at 6:44 PM Bináris wikiposta@gmail.com wrote:
We are on a really bad track. _______________________________________________ pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
I would appreciate it if people gave me a few days before abandoning all my patches.
I will be rotating back onto pywikibot next week, as I am mentoring a Pywikibot GSOC project, and will start to go through my patches.
Also, the other thread about developing a roadmap is a very good idea. That will help people with large sets of stale patches to work out what needs to be worked on first.
On Thu, May 25, 2017 at 9:49 PM, Maarten Dammers maarten@mdammers.nl wrote:
Hi everyone,
On the recent hackathon in Vienna we talked about the large number of changes still open and how to get the flow back. We currently have over 300 open changes going back to 2014 ( https://gerrit.wikimedia.org/r/#/q/status:open+project:pywikibot/core ). A change is in Gerrit because the developer wants code review to get it merged. Code review might not be a lot of fun and this is made worse by this huge backlog. A lot of the changes have issues preventing this:
- Merge conflict, needs to be rebased
- Not verified, tests fail
- Code review -1, -2
My proposal is to abandon the changes we're not going to work on anyway and focus our attention on the changes we do want to get merged. I understand that some changes in which people invested a lot of time and effort will get abandoned, but I think the benefit of getting the code review process back on track is higher. Abandoned changes are not gone, we can always open them again.
I ask everyone who has (a lot of) old open changes to have a look at them and make the decision: Pick it up or abandon. If the change is linked to a phabricator task, it would be nice to update the task too.
Thank you,
Maarten
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
Sorry I've been delayed, as we needed to get this patch operational in order to possibly have Revision.thank() as part of the Thanks project.
https://gerrit.wikimedia.org/r/#/c/192539/
Are there any other patches around which attempt to make Revision an entity that can have methods that perform API queries?
On Sat, May 27, 2017 at 1:13 AM, John Mark Vandenberg jayvdb@gmail.com wrote:
I would appreciate it if people gave me a few days before abandoning all my patches.
I will be rotating back onto pywikibot next week, as I am mentoring a Pywikibot GSOC project, and will start to go through my patches.
Also, the other thread about developing a roadmap is a very good idea. That will help people with large sets of stale patches to work out what needs to be worked on first.
On Thu, May 25, 2017 at 9:49 PM, Maarten Dammers maarten@mdammers.nl wrote:
Hi everyone,
On the recent hackathon in Vienna we talked about the large number of changes still open and how to get the flow back. We currently have over 300 open changes going back to 2014 ( https://gerrit.wikimedia.org/r/#/q/status:open+project:pywikibot/core ). A change is in Gerrit because the developer wants code review to get it merged. Code review might not be a lot of fun and this is made worse by this huge backlog. A lot of the changes have issues preventing this:
- Merge conflict, needs to be rebased
- Not verified, tests fail
- Code review -1, -2
My proposal is to abandon the changes we're not going to work on anyway and focus our attention on the changes we do want to get merged. I understand that some changes in which people invested a lot of time and effort will get abandoned, but I think the benefit of getting the code review process back on track is higher. Abandoned changes are not gone, we can always open them again.
I ask everyone who has (a lot of) old open changes to have a look at them and make the decision: Pick it up or abandon. If the change is linked to a phabricator task, it would be nice to update the task too.
Thank you,
Maarten
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
-- John Vandenberg