Hi,
I've sent my first patch for code review ( https://gerrit.wikimedia.org/r/#/c/138661/)
As part of the review, it was noted that I should move a 'msg' variable into scripts/i18n. I have done so, however now I'm wondering what the review process for code in that submodule?
Is there a way to add my i18n code to the same gerrit review? Conceptually it is one change, though I'm not sure if maybe the way the i18n works is that the script can function with the corresponding i18n script missing. Is that possible?
Thanks, -Travis
----- Original Nachricht ---- Von: Travis Briggs audiodude@gmail.com An: pywikipedia-l@lists.wikimedia.org Datum: 12.06.2014 02:41 Betreff: [Pywikipedia-l] (core) Adding code in scripts/i18n to gerrit review
Hi,
I've sent my first patch for code review ( https://gerrit.wikimedia.org/r/#/c/138661/)
As part of the review, it was noted that I should move a 'msg' variable into scripts/i18n. I have done so, however now I'm wondering what the review process for code in that submodule?
Is there a way to add my i18n code to the same gerrit review? Conceptually it is one change, though I'm not sure if maybe the way the i18n works is that the script can function with the corresponding i18n script missing. Is that possible?
Thanks, -Travis
You can't. You must not use scripts/i18n directly but you have to commit the messages dict to pywikibot-i18n repository
Greetings xqt
Okay, so my follow up question is about this line:
comment = i18n.twtranslate(pywikibot.Site(), "selflink-remove")
Will that somehow work properly before the scripts/i18n code is submitted? Or do I have to submit the i18n code first and then make the core scripts change?
Thanks! -Travis
On 12 June 2014 09:22, info@gno.de wrote:
----- Original Nachricht ---- Von: Travis Briggs audiodude@gmail.com An: pywikipedia-l@lists.wikimedia.org Datum: 12.06.2014 02:41 Betreff: [Pywikipedia-l] (core) Adding code in scripts/i18n to gerrit review
Hi,
I've sent my first patch for code review ( https://gerrit.wikimedia.org/r/#/c/138661/)
As part of the review, it was noted that I should move a 'msg' variable into scripts/i18n. I have done so, however now I'm wondering what the review process for code in that submodule?
Is there a way to add my i18n code to the same gerrit review?
Conceptually
it is one change, though I'm not sure if maybe the way the i18n works is that the script can function with the corresponding i18n script missing.
Is
that possible?
Thanks, -Travis
You can't. You must not use scripts/i18n directly but you have to commit the messages dict to pywikibot-i18n repository
Greetings xqt
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l