-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello all!
I updated [1] and added the section "Example (step-by-step)" in order to help others with the first steps - it's not straight forward... :)
[1] http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Gerrit
But now I would like to review and correct the change
https://gerrit.wikimedia.org/r/#/c/76352/
but just get
$ git review -d 76352 Could not parse json query response: u'Verified'
...can somebody help me here and explain whats going on and what I am doing wrong?
Thanks a lot and Greetings DrTrigon
On 28 July 2013 23:14, Dr. Trigon dr.trigon@surfeu.ch wrote:
I updated [1] and added the section "Example (step-by-step)" in order to help others with the first steps - it's not straight forward... :)
[1] http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Gerrit
Cool!
But now I would like to review and correct the change
https://gerrit.wikimedia.org/r/#/c/76352/
but just get
$ git review -d 76352 Could not parse json query response: u'Verified'
...can somebody help me here and explain whats going on and what I am doing wrong?
Which git review version are you using? It works for me:
valhallasw@lisilwen:~/src/pywikibot-core$ git review --version git-review version 1.12 valhallasw@lisilwen:~/src/pywikibot-core$ git review -d 76352 Enter passphrase for key '/home/valhallasw/.ssh/id_rsa': Downloading refs/changes/52/76352/1 from gerrit into review/drtrigon/gitconfig Enter passphrase for key '/home/valhallasw/.ssh/id_rsa': Switched to branch 'review/drtrigon/gitconfig'
Merlijn
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
But now I would like to review and correct the change
https://gerrit.wikimedia.org/r/#/c/76352/
but just get
$ git review -d 76352 Could not parse json query response: u'Verified'
...can somebody help me here and explain whats going on and what I am doing wrong?
Which git review version are you using? It works for me:
valhallasw@lisilwen:~/src/pywikibot-core$ git review --version git-review version 1.12 valhallasw@lisilwen:~/src/pywikibot-core$ git review -d 76352 Enter passphrase for key '/home/valhallasw/.ssh/id_rsa': Downloading refs/changes/52/76352/1 from gerrit into review/drtrigon/gitconfig Enter passphrase for key '/home/valhallasw/.ssh/id_rsa': Switched to branch 'review/drtrigon/gitconfig'
Just to be sure, I did a complete new clone as described by "Example (step-by-step)" and then get:
$ git review --version git-review version 1.18 $ git review -d 76352 Could not parse json query response: u'Verified'
... so ... might the version be the problem?
DrTrigon
On 29 July 2013 15:50, Dr. Trigon dr.trigon@surfeu.ch wrote:
... so ... might the version be the problem?
Unlikely, considering you are running a newer version. Could you try
running
git review --verbose -d 76352
and see if that gives any useful output?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 29.07.2013 15:53, Merlijn van Deen wrote:
On 29 July 2013 15:50, Dr. Trigon <dr.trigon@surfeu.ch mailto:dr.trigon@surfeu.ch> wrote:
... so ... might the version be the problem?
Unlikely, considering you are running a newer version. Could you try running
...this is what one MIGHT usually think... ;))
git review --verbose -d 76352
and see if that gives any useful output?
$ git review --verbose -d 76352 2013-07-29 16:08:21.270583 Running: git log --color=never --oneline HEAD^1..HEAD 2013-07-29 16:08:21.273990 Running: git remote 2013-07-29 16:08:21.276615 Running: git branch -a --color=never 2013-07-29 16:08:21.279382 Running: git remote show -n gerrit Found origin Push URL: ssh://drtrigon@gerrit.wikimedia.org:29418/pywikibot/core.git 2013-07-29 16:08:21.282819 Running: ssh -x -p 29418 -l drtrigon gerrit.wikimedia.org gerrit query --format=JSON --current-patch-set change:76352 == output == {"project":"pywikibot/core","branch":"master","topic":"gitconfig","id":"Iec4e2a4525185890546663c8702ad17370fee70c","number":"76352","subject":"improvement; add httplib2 as submodule - setuptools still missing","owner":{"name":"DrTrigon","email":"dr.trigon@surfeu.ch","username":"drtrigon"},"url":"https://gerrit.wikimedia.org/r/76352%22,%22createdOn%22:1375034327,%22lastUp... van Deen","email":"valhallasw@arctus.nl","username":"valhallasw"}}],"sizeInsertions":9,"sizeDeletions":-6}} {"type":"stats","rowCount":1,"runTimeMilliseconds":15} == output end == Could not parse json query response: u'Verified'
...loos like something with the "approvals" part does not work as expected...
On 29 July 2013 16:11, Dr. Trigon dr.trigon@surfeu.ch wrote:
{"project":"pywikibot/core","branch":"master","topic":"gitconfig","id":" Iec4e2a4525185890546663c8702ad17370fee70c","number":"76352", "subject":"improvement; add httplib2 as submodule - setuptools still missing","owner":{"name":"DrTrigon","email":"dr.trigon@surfeu.ch ","username":"drtrigon"},"url":"https://gerrit.wikimedia.org/r/76352 ","createdOn":1375034327,"lastUpdated":1375035596,"sortKey":"0026b5eb00012a40","open":true,"status":"NEW","currentPatchSet":{"number":"1","revision":"690ad98bf3d03ef4b030e74e8812e465f61e07ca","parents":["188f157c2926a8409cba94c95d09d74b521f3dd7"],"ref":"refs/changes/52/76352/1","uploader":{"name":"DrTrigon","email":" dr.trigon@surfeu.ch ","username":"drtrigon"},"createdOn":1375034327,"author":{"name":"DrTrigon","email":" dr.trigon@surfeu.ch ","username":"drtrigon"},"approvals":[{"type":"Verified","description":"Verified","value":"2","grantedOn":1375034328,"by":{"name":"jenkins-bot","username":"jenkins-bot"}},{"type":"Code-Review","description":"Code-Review","value":"-2","grantedOn":1375035423,"by":{"name":"Merlijn van Deen","email":"valhallasw@arctus.nl ","username":"valhallasw"}}],"sizeInsertions":9,"sizeDeletions":-6}} {"type":"stats","rowCount":1,"runTimeMilliseconds":15}
Basically, this is the same result I get. I'd suggest upgrading (or downgrading...) your git-review. Both 1.12 (1.12-0ubuntu1) and 1.21 (1.21-0ubuntu1) work for me.
Merlijn
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 29.07.2013 17:04, Merlijn van Deen wrote:
On 29 July 2013 16:11, Dr. Trigon <dr.trigon@surfeu.ch mailto:dr.trigon@surfeu.ch> wrote:
{"project":"pywikibot/core","branch":"master","topic":"gitconfig","id":"Iec4e2a4525185890546663c8702ad17370fee70c","number":"76352","subject":"improvement;
add httplib2 as submodule - setuptools still
missing","owner":{"name":"DrTrigon","email":"dr.trigon@surfeu.ch mailto:dr.trigon@surfeu.ch","username":"drtrigon"},"url":"https://gerrit.wikimedia.org/r/76352%22,%22createdOn%22:1375034327,%22lastUp...
mailto:dr.trigon@surfeu.ch","username":"drtrigon"},"createdOn":1375034327,"author":{"name":"DrTrigon","email":"dr.trigon@surfeu.ch
mailto:dr.trigon@surfeu.ch","username":"drtrigon"},"approvals":[{"type":"Verified","description":"Verified","value":"2","grantedOn":1375034328,"by":{"name":"jenkins-bot","username":"jenkins-bot"}},{"type":"Code-Review","description":"Code-Review","value":"-2","grantedOn":1375035423,"by":{"name":"Merlijn
van
Deen","email":"valhallasw@arctus.nl mailto:valhallasw@arctus.nl","username":"valhallasw"}}],"sizeInsertions":9,"sizeDeletions":-6}}
{"type":"stats","rowCount":1,"runTimeMilliseconds":15}
Basically, this is the same result I get. I'd suggest upgrading (or downgrading...) your git-review. Both 1.12 (1.12-0ubuntu1) and 1.21 (1.21-0ubuntu1) work for me.
Now thats ugly... You are right (did you try 1.18 too?) !!
Downloading 1.12 [1] from koji [2] with the drawback that I am forced to use a fedora 17 package on fc19 solved the problem!
[1] http://arm.koji.fedoraproject.org//packages/git-review/1.12/2.fc17/noarch/gi... [2] http://arm.koji.fedoraproject.org/koji/buildinfo?buildID=53588
Thanks a lot for your help - hope this helps others too! Greetings!!