Hey, There are about 200 open patches in pywikibot right now, huge part of them are obsolete, really problematic, or redundant patches.
Please revise your old patches and abandon ones that are not needed anymore.
Best
On Sun, Feb 22, 2015 at 7:40 PM, Amir Ladsgroup ladsgroup@gmail.com wrote:
Hey, There are about 200 open patches in pywikibot right now, huge part of them are obsolete, really problematic, or redundant patches.
Can you identify some that fit into these categories? Maybe add a note on them recommending what should be done?
On Sun, Feb 22, 2015 at 10:16 PM, John Mark Vandenberg jayvdb@gmail.com wrote:
On Sun, Feb 22, 2015 at 7:40 PM, Amir Ladsgroup ladsgroup@gmail.com wrote:
Hey, There are about 200 open patches in pywikibot right now, huge part of them are obsolete, really problematic, or redundant patches.
Can you identify some that fit into these categories? Maybe add a note on them recommending what should be done?
Careful what I ask for I guess.
Amir, please do not spam people unnecessarily.
you say 'needs rebase' to this patch, which has two -1's on it.
https://gerrit.wikimedia.org/r/#/c/141392/
It needs more than a rebase, so please dont do that. Many of the other comments you are adding are equally useless.
So what do you suggest? If a CS is old enough, rebase is the least of the problems.
On Sun, Feb 22, 2015 at 3:00 PM, John Mark Vandenberg jayvdb@gmail.com wrote:
On Sun, Feb 22, 2015 at 10:16 PM, John Mark Vandenberg jayvdb@gmail.com wrote:
On Sun, Feb 22, 2015 at 7:40 PM, Amir Ladsgroup ladsgroup@gmail.com
wrote:
Hey, There are about 200 open patches in pywikibot right now, huge part of
them
are obsolete, really problematic, or redundant patches.
Can you identify some that fit into these categories? Maybe add a note on them recommending what should be done?
Careful what I ask for I guess.
Amir, please do not spam people unnecessarily.
you say 'needs rebase' to this patch, which has two -1's on it.
https://gerrit.wikimedia.org/r/#/c/141392/
It needs more than a rebase, so please dont do that. Many of the other comments you are adding are equally useless.
-- John Vandenberg
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
On Sun, Feb 22, 2015 at 10:33 PM, Amir Ladsgroup ladsgroup@gmail.com wrote:
So what do you suggest? If a CS is old enough, rebase is the least of the problems.
What is the problem that you are trying to solve?
Gerrit allows filtering by review status using url parameters, etc, so 'too many patches' is hardly a problem. You can bookmark patches which are not -1'd.
If there are patches which are fundamentally wrong, adding -2 and abandoning them is helpful. Reviewing possibly problematic patches is helpful. Rebasing other peoples patches is helpful, especially if you also address the minor review issues.
Many of the patches have put on hold due to other larger problems; the dependencies are sometimes explained in the comments; if not, asking why a good patch is on hold is useful.
But pushing old patches onto the top of the queue for no reason and without a review comment, that is not helpful.
The main concern is losing good but on-hold patches in a big load of redundant, obsolete and problematic patches.
I start reviewing and rebasing, etc.
On Sun, Feb 22, 2015 at 3:18 PM, John Mark Vandenberg jayvdb@gmail.com wrote:
On Sun, Feb 22, 2015 at 10:33 PM, Amir Ladsgroup ladsgroup@gmail.com wrote:
So what do you suggest? If a CS is old enough, rebase is the least of the problems.
What is the problem that you are trying to solve?
Gerrit allows filtering by review status using url parameters, etc, so 'too many patches' is hardly a problem. You can bookmark patches which are not -1'd.
If there are patches which are fundamentally wrong, adding -2 and abandoning them is helpful. Reviewing possibly problematic patches is helpful. Rebasing other peoples patches is helpful, especially if you also address the minor review issues.
Many of the patches have put on hold due to other larger problems; the dependencies are sometimes explained in the comments; if not, asking why a good patch is on hold is useful.
But pushing old patches onto the top of the queue for no reason and without a review comment, that is not helpful.
-- John Vandenberg
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Let's start with rebasing old patches and see if they are still valid.
Best
On Sun, Feb 22, 2015 at 2:46 PM, John Mark Vandenberg jayvdb@gmail.com wrote:
On Sun, Feb 22, 2015 at 7:40 PM, Amir Ladsgroup ladsgroup@gmail.com wrote:
Hey, There are about 200 open patches in pywikibot right now, huge part of
them
are obsolete, really problematic, or redundant patches.
Can you identify some that fit into these categories? Maybe add a note on them recommending what should be done?
-- John Vandenberg
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l