Patches item #1773928, was opened at 2007-08-14 11:05 Message generated for change (Settings changed) made by russblau You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1773928...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None

Status: Closed

Resolution: None Priority: 5 Private: No Submitted By: Aurimas Fischer (ebola_rulez) Assigned to: Daniel Herding (wikipedian) Summary: bug in redirect.py -xml

Initial Comment: redirect.py double|broken -xml misses pages containing spaces in their titles.

Attached patch fixes this bug.

----------------------------------------------------------------------

Comment By: Daniel Herding (wikipedian) Date: 2007-09-13 16:33

Message: Logged In: YES user_id=880694 Originator: NO

Fixed. There's still a namespace bug, as entry.title only gives the title without namespace.

----------------------------------------------------------------------

Comment By: Aurimas Fischer (ebola_rulez) Date: 2007-09-13 15:14

Message: Logged In: YES user_id=959303 Originator: YES

Indeed, there is. redirect.py double -xml:db.xml: File "C:\pywikipedia\redirect.py", line 143, in get_redirects_from_dump print len(pageTitles) UnboundLocalError: local variable 'pageTitles' referenced before assignment

redirect.py broken -xml:db.xml: File "C:\pywikipedia\redirect.py", line 170, in retrieve_broken_redirects if value not in pagetitles: NameError: global name 'pagetitles' is not defined

----------------------------------------------------------------------

Comment By: Daniel Herding (wikipedian) Date: 2007-09-13 15:12

Message: Logged In: YES user_id=880694 Originator: NO

I applied redirect_py.patch and fixed the two references to 'target'. The script still needs some testing, maybe there are more bugs.

----------------------------------------------------------------------

Comment By: Aurimas Fischer (ebola_rulez) Date: 2007-09-13 14:50

Message: Logged In: YES user_id=959303 Originator: YES

P.P.S. revision 4275 broke deouble redirect fixing. "NameError: global name 'target' is not defined" in fix_double_redirects(self) lines ~245, ~257

----------------------------------------------------------------------

Comment By: Aurimas Fischer (ebola_rulez) Date: 2007-09-13 14:34

Message: Logged In: YES user_id=959303 Originator: YES

redirect.py double -xml:db.xml doesn't find double redirects with spaces in page title.

Updated patch to work with latest revision.

P.S. redirect.py broken -xml:db.xml is broken in revision 4275. File Added: redirect_py.patch

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1773928...