https://www.mediawiki.org/wiki/Manual:Pywikibot/Gerrit
“Remember to follow the commit message guidelines.” (no link to those)
https://www.mediawiki.org/wiki/Manual:Pywikibot/Development
“Remember to follow the commit message guidelines.” (no link to those)
So, where are they? I’m about to send a commit for review and I will most likely fail to conform with whatever guidelines/rules there are on commit messages.
Hi Adrián,
Please see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines .
-Yusuke
On Tue, Aug 12, 2014 at 2:37 PM, Adrián Chaves Fernández adriyetichaves@gmail.com wrote:
https://www.mediawiki.org/wiki/Manual:Pywikibot/Gerrit
"Remember to follow the commit message guidelines." (no link to those)https://www.mediawiki.org/wiki/Manual:Pywikibot/Development
"Remember to follow the commit message guidelines." (no link to those)So, where are they? I'm about to send a commit for review and I will most likely fail to conform with whatever guidelines/rules there are on commit messages.
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
On 8/11/14, 10:37 PM, Adrián Chaves Fernández wrote:
So, where are they? I’m about to send a commit for review and I will most likely fail to conform with whatever guidelines/rules there are on commit messages.
Don't worry too much about the guidelines, it's very easy to fix commit messages before we merge changes. The tl;dr is that your message should explain what you're trying to do and why, including links to any relevant bug reports if they exist.
Once you start submitting more patches (hopefully :)), it would be a good idea to read through the guidelines.
-- Legoktm