Dear all
I have created a patch for the site.search function as it often returned too many results which did not include the word I searched for. This patch should solve the problem on the bot side as I couldnt quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
https://github.com/wikimedia/pywikibot-core/pull/9
I hope you could have a look at the patches and maybe direct me to a better place to post these if you are interested in them.
Best regards
Hannes Roest
Hi Hannes,
quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
The easiest way to commit a patch is using the gerrit patch uploader. You'll found it there:
https://tools.wmflabs.org/gerrit-patch-uploader/
Best xqt
----- Original Nachricht ---- Von: Hannes Röst hroest_nospam2333@quantentunnel.de An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 12.02.2016 23:08 Betreff: [pywikibot] Patch for site.search
Dear all
I have created a patch for the site.search function as it often returned too many results which did not include the word I searched for. This patch should solve the problem on the bot side as I couldnt quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
https://github.com/wikimedia/pywikibot-core/pull/9
I hope you could have a look at the patches and maybe direct me to a better place to post these if you are interested in them.
Best regards
Hannes Roest
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
The alternative is to use gerrit directly. The instructions are on https://m.mediawiki.org/wiki/Gerrit and the repo is at https://gerrit.wikimedia.org/r/pywikibot/core
/ André On 13 Feb 2016 11:18, info@gno.de wrote:
Hi Hannes,
quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
The easiest way to commit a patch is using the gerrit patch uploader. You'll found it there:
https://tools.wmflabs.org/gerrit-patch-uploader/
Best xqt
----- Original Nachricht ---- Von: Hannes Röst hroest_nospam2333@quantentunnel.de An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 12.02.2016 23:08 Betreff: [pywikibot] Patch for site.search
Dear all
I have created a patch for the site.search function as it often returned too many results which did not include the word I searched for. This patch should solve the problem on the bot side as I couldnt quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
https://github.com/wikimedia/pywikibot-core/pull/9
I hope you could have a look at the patches and maybe direct me to a better place to post these if you are interested in them.
Best regards
Hannes Roest
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
Dear all
Thanks for your help. I have managed (after a lot of work getting gerrit to work correctly) to upload a patch: https://gerrit.wikimedia.org/r/#/c/272655/1
Gerrit told me to squash all my commits (I didnt have the change-id) to a single commit, and I managed to convince jenkins to take my patch. I also added some sample code to show the effect of the patch and I added a testcase to the test file in the tests/ folder.
Best regards
Hannes
On 13 February 2016 at 04:10, André Costa andre.costa@wikimedia.se wrote:
The alternative is to use gerrit directly. The instructions are on https://m.mediawiki.org/wiki/Gerrit and the repo is at https://gerrit.wikimedia.org/r/pywikibot/core
/ André
On 13 Feb 2016 11:18, info@gno.de wrote:
Hi Hannes,
quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
The easiest way to commit a patch is using the gerrit patch uploader. You'll found it there:
https://tools.wmflabs.org/gerrit-patch-uploader/
Best xqt
----- Original Nachricht ---- Von: Hannes Röst hroest_nospam2333@quantentunnel.de An: Pywikibot discussion list pywikibot@lists.wikimedia.org Datum: 12.02.2016 23:08 Betreff: [pywikibot] Patch for site.search
Dear all
I have created a patch for the site.search function as it often returned too many results which did not include the word I searched for. This patch should solve the problem on the bot side as I couldnt quite figure out whether there is a solution on the API side. Also, I didnt quite know where to post the patches, so I made a github pull request
https://github.com/wikimedia/pywikibot-core/pull/9
I hope you could have a look at the patches and maybe direct me to a better place to post these if you are interested in them.
Best regards
Hannes Roest
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot