Hi everyone,
Per bug 64881[1], I have copied all of compat's wikitionary/ folder into a separate repository named pywikibot/wiktionary. I also did some minor pep8-ification[2]. The tests were failing though[3], and I don't understand the code enough to fix them.
However, now compat also has a copy of the code. Should we just turn wiktionary/ into a submodule pointing at the separate repository?
Also, AFAIS wiktionary.py is just a copy of all the individual files combined together. I'm not sure what to do with it.
[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=64881 [2] https://gerrit.wikimedia.org/r/#/c/148243/ [3] https://bugzilla.wikimedia.org/show_bug.cgi?id=68348
-- Legoktm
If pywikibot/wiktionary is reasonably useful for the core branch, then supporting 'compat' is less important. If /wiktionary could take advantage of some features of 'core' which 'compat' does not have, IMHO compat should be left with its old version and /wiktionary be added as submodule in core.
Il 22/07/2014 00:39, Legoktm ha scritto:
Hi everyone,
Per bug 64881[1], I have copied all of compat's wikitionary/ folder into a separate repository named pywikibot/wiktionary. I also did some minor pep8-ification[2]. The tests were failing though[3], and I don't understand the code enough to fix them.
However, now compat also has a copy of the code. Should we just turn wiktionary/ into a submodule pointing at the separate repository?
Also, AFAIS wiktionary.py is just a copy of all the individual files combined together. I'm not sure what to do with it.
[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=64881 [2] https://gerrit.wikimedia.org/r/#/c/148243/ [3] https://bugzilla.wikimedia.org/show_bug.cgi?id=68348
-- Legoktm
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
On Tue, Jul 22, 2014 at 8:46 AM, Ricordisamoa ricordisamoa@openmailbox.org wrote:
.. IMHO compat should be left with its old version and /wiktionary be added as submodule in core.
I agree with this solution.
Could we arrange a hack 'day' when someone familiar with the code is available, and others help get the new repo working correctly on top of core?
On 7/21/14, 6:56 PM, John Mark Vandenberg wrote:
On Tue, Jul 22, 2014 at 8:46 AM, Ricordisamoa ricordisamoa@openmailbox.org wrote:
.. IMHO compat should be left with its old version and /wiktionary be added as submodule in core.
I agree with this solution.
Could we arrange a hack 'day' when someone familiar with the code is available, and others help get the new repo working correctly on top of core?
Here's the thing...the code is entirely framework-independent, except for wiktionary.py which has 10 lines of framework-specific code (easily fixed by s/wikipedia/pywikibot/). It's basically some wikitext parsing and OO code. wiktionary.py reads from a text file[1].
[1] https://github.com/wikimedia/pywikibot-compat/blob/master/wiktionary.py#L130...
-- Legoktm
Sort of related, I see there is no http://test.wiktionary.org/ ;-(
On Tue, Jul 22, 2014 at 1:53 PM, Legoktm legoktm.wikipedia@gmail.com wrote:
On 7/21/14, 6:56 PM, John Mark Vandenberg wrote:
On Tue, Jul 22, 2014 at 8:46 AM, Ricordisamoa ricordisamoa@openmailbox.org wrote:
.. IMHO compat should be left with its old version and /wiktionary be added as submodule in core.
I agree with this solution.
Could we arrange a hack 'day' when someone familiar with the code is available, and others help get the new repo working correctly on top of core?
Here's the thing...the code is entirely framework-independent, except for wiktionary.py which has 10 lines of framework-specific code (easily fixed by s/wikipedia/pywikibot/). It's basically some wikitext parsing and OO code. wiktionary.py reads from a text file[1].
[1] https://github.com/wikimedia/pywikibot-compat/blob/master/wiktionary.py#L130...
-- Legoktm
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
It's better to have it under bots submodule, per previous talks. Something like "bots/wiktionary"
Best
On 7/22/14, John Mark Vandenberg jayvdb@gmail.com wrote:
Sort of related, I see there is no http://test.wiktionary.org/ ;-(
On Tue, Jul 22, 2014 at 1:53 PM, Legoktm legoktm.wikipedia@gmail.com wrote:
On 7/21/14, 6:56 PM, John Mark Vandenberg wrote:
On Tue, Jul 22, 2014 at 8:46 AM, Ricordisamoa ricordisamoa@openmailbox.org wrote:
.. IMHO compat should be left with its old version and /wiktionary be added as submodule in core.
I agree with this solution.
Could we arrange a hack 'day' when someone familiar with the code is available, and others help get the new repo working correctly on top of core?
Here's the thing...the code is entirely framework-independent, except for wiktionary.py which has 10 lines of framework-specific code (easily fixed by s/wikipedia/pywikibot/). It's basically some wikitext parsing and OO code. wiktionary.py reads from a text file[1].
[1] https://github.com/wikimedia/pywikibot-compat/blob/master/wiktionary.py#L130...
-- Legoktm
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
-- John Vandenberg
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l