2009/6/10 alexsh@svn.wikimedia.org:
Revision: 6946 Author: alexsh Date: 2009-06-09 18:22:04 +0000 (Tue, 09 Jun 2009)
Log Message:
*config.py -preSet globalAccount flag -remove no use comment. *family.py -add cross_allowed for global bot flag -update ns-info by update_namespaces.py *families -add allowed languages -update ns-info by update_namespaces.py -fix oldwikisource link faild when SSL *login.py:typo *spamremove.py:typo for syntax in msgs *speedy_delete.py:add new template for zhwiki *wikipedia.py -site._getUserData:detect global bot flag. -translate: add keyword "_default" -output: ignore print_stack raise None when OS in windows
Come on Alex, even the commit message is barely readable. Do you realize that no-one will be able to review your changes because they are too many of them?
Because no one can reasonably take the time to review such a _huge_ changeset, it is only a loss of time: * If we don't review it, it might include lots of errors, and we will lose time fixing mistakes later * If someone takes time to understand all your changes, he'll lose an important part of his time...
You should _really_ commit each feature separately. Commit often. Commit small, consistent bits. A small patch can be reviewed in 10 seconds, it barely takes time. Do not commit Huge patches every week, with multiple features. This is a pain.
And subscribe to pywikipedia-l. (forwarding to his zh userpage)