Hi xqt,
First of all, thanks for all the effort you're putting into pywikipediabot. However,
On 26 December 2010 17:43, xqt@svn.wikimedia.org wrote:
Log Message:
Some Russian and Ukrainian translations; minor changes from rewrite
Could you split such commits, please, into one 'translation' commit (or even better: two, one for russian and one for ukrainian), and one rewrite-to-trunk port?
Additionally, this:
- ['Yes', 'No', 'Add an alternative', 'Give up'],
- ['y', 'n', 'a', 'g'])
- ['Yes', 'No', 'Add an alternative', 'Give up'],
- ['y', 'n', 'a', 'g'])
seems to be a purely whitespace change. Could you check diffs to prevent committing them?
Thanks!
Merlijn
Hi Merlijn,
I sometimes compare trunk version with rewrite code while updating some stuff. This helps keeping both version up to date and it is easier to merge both branches which is sometimes a bit messy. But it is not a problem to make several commits for different things if it helps keeping commits tracking more clearly (or what is your main reason in this matter?).
Greetings and a happy new year
xqt
----- Original Nachricht ---- Von: Merlijn van Deen valhallasw@arctus.nl An: pywikipedia-l@lists.wikimedia.org Datum: 27.12.2010 14:44 Betreff: Re: [Pywikipedia-l] [Pywikipedia-svn] SVN: [8805] trunk/pywikipedia
Hi xqt,
First of all, thanks for all the effort you're putting into pywikipediabot. However,
On 26 December 2010 17:43, xqt@svn.wikimedia.org wrote:
Log Message:
Some Russian and Ukrainian translations; minor changes from rewrite
Could you split such commits, please, into one 'translation' commit (or even better: two, one for russian and one for ukrainian), and one rewrite-to-trunk port?
Additionally, this:
- ['Yes', 'No', 'Add
an alternative', 'Give up'],
- ['y', 'n', 'a',
'g'])
- ['Yes', 'No', 'Add an
alternative', 'Give up'],
- ['y', 'n', 'a', 'g'])
seems to be a purely whitespace change. Could you check diffs to prevent committing them?
Thanks!
Merlijn
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Hi xqt,
First of all, a happy new year to you, too!
On 31 December 2010 15:58, info@gno.de wrote:
if it helps keeping commits tracking more clearly (or what is your main reason in this matter?).
This indeed is the main reason; the commit message preferably clearly states what happened in that revision, as this makes tracing the origin of a bug much easier. Splitting it into commits also makes code review much easier: as the changes then happen in clear, seperate, commits.
Thanks for your response, and code on ;-)
Merlijn