Hello,
Currently in setup.py, we call generate_user_files.py, which requires interactive input. This is bad for package managers like the bug report mentions, and also for pypi/pip.
Removing it is a little more difficult for users, they need to now run both setup.py and generate_user_files.py, but I think that's an ok tradeoff. Most users will be using the pwb.py script anyways, so this wouldn't even affect them.
Thoughts?
Bug link: https://bugzilla.wikimedia.org/555843 What Arch is using: https://aur.archlinux.org/packages/py/python2-pywikibot-git/PKGBUILD
-- Legoktm
PS: bug 55584 is blocking packaging too, if someone wants to fix that :)
On Sat, Dec 14, 2013 at 5:40 PM, legoktm legoktm.wikipedia@gmail.com wrote:
Bug link: https://bugzilla.wikimedia.org/555843
Sorry, this should be https://bugzilla.wikimedia.org/55583
--Legoktm
On 15 December 2013 02:40, legoktm legoktm.wikipedia@gmail.com wrote:
Currently in setup.py, we call generate_user_files.py, which requires interactive input. This is bad for package managers like the bug report mentions, and also for pypi/pip.
Removing it is a little more difficult for users, they need to now run both setup.py and generate_user_files.py, but I think that's an ok tradeoff. Most users will be using the pwb.py script anyways, so this wouldn't even affect them.
I have submitted a patch for the first one -- if a tty is attached, it asks to create a user-config, otherwise it does not. https://gerrit.wikimedia.org/r/101662
As for the second one: I hate setuptools. Finally giving a packages=[...] parameter /is/ the right way, but it only takes effect if you first rm -rf build/. https://gerrit.wikimedia.org/r/101661
Merlijn