Not sure if it is a good idea to remove the 'same as default' values after adding it.
The "None" choices were made intentionally, and with those values no longer being there, it will be possible to add a translation again. So even though the default may be a good idea, intentionally setting a language value as being equal to the default value should be allowed and preserved in case it makes sense, IMO.
Any other opinions?
Siebrand
-----Original Message----- From: pywikipedia-svn-bounces@lists.wikimedia.org [mailto:pywikipedia-svn-bounces@lists.wikimedia.org] On Behalf Of alexsh@mayflower.esams.wikimedia.org Sent: Thursday, October 22, 2009 6:55 PM To: pywikipedia-svn@lists.wikimedia.org Subject: [Pywikipedia-svn] SVN: [7525] trunk/pywikipedia/welcome.py
Revision: 7525 Author: alexsh Date: 2009-10-23 01:55:05 +0000 (Fri, 23 Oct 2009)
Log Message: ----------- clear logbook parameter
Modified Paths: -------------- trunk/pywikipedia/welcome.py
Modified: trunk/pywikipedia/welcome.py =================================================================== --- trunk/pywikipedia/welcome.py 2009-10-21 21:10:29 UTC (rev 7524) +++ trunk/pywikipedia/welcome.py 2009-10-23 01:55:05 UTC (rev 7525) @@ -203,25 +203,17 @@ logbook = { 'commons': {'_default': u'Project:Welcome log', }, 'wikipedia': { + '_default': None, 'ar': u'Project:??? ???????', - 'da': None, # no welcome log on da.wiki - 'de': None, # no welcome log on de.wiki - 'en': u'Project:Welcome log', 'fa': u'Project:????? ??????', 'fr': u'Wikipedia:Prise de décision/Accueil automatique des nouveaux par un robot/log', 'ga': u'Project:Log fáilte', - 'he': None, # no welcome log on he.wiki - 'id': None, # no welcome log on id.wiki 'it': u'Project:Benvenuto Bot/Log', 'ja': u'???:Alexbot/Welcomebot??', - 'ka': None, # no welcome log on ka.wiki 'nl': u'Project:Logboek welkom', 'no': u'Project:Velkomstlogg', - 'pt': None, # no welcome log on pt.wiki - 'ru': None, # no welcome log on ru.wiki 'sq': u'Project:Tung log', 'sr': u'Project:????????????', - 'vo': None, # no welcome log on vo.wiki 'zh': u'User:Welcomebot/????',