Hi all! I apologize for being a naggy poo-poo pants but does anyone
have time to code review incoming contributions?
I have fifteen reviews that are awaiting a reply [1], and writing code
just to have it shelved is beginning to make me wonder if pywikibot is
a good project to contribute toward. Xqt is the only person that
routinely reviews contributions, and he often doesn't have time to
follow up after an initial comment. Code review responsibility
shouldn't rely on one person, but our lack of reviewers unfortunately
disincentives volunteering.
My changes are unimportant. Just type hints along with some script
refactoring that's been stuck a month. But code review responsiveness
has been a persistent pain point so I'm wondering if there's anything
we'd care to do to systematically improve this (scheduled reviewer
rotation, escalate stalled reviews, periodic 'code review parties',
etc).
Cheers! -Damian
[1] Here's my reviews...
Script refactoring:
1.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/700718
2.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/703015
3.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/704603
Type hints:
1.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709251
2.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709252
3.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709590
4.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709832
5.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709253
6.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/709236
7.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710116
8.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710382
9.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710615
10.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710612
11.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710673
12.
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710675