On Mon, 10 Aug 2015 23:20 Ricordisamoa <ricordisamoa(a)openmailbox.org> wrote:
! In
T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is
pointless since the point of code
review is that //others// review your code.
I'm pretty sure others know
you approve your own patches, unless stated otherwise by marking the
patch as "work in progress".
While Ciencia_Al_Poder may believe that Paladox approves all of their
own patches, especially after many pointless rebases as documented in
T106359, it is funny if you think that Fabian or I automatically
approve of all our own patches. Often they are only demonstrating a
problem, a possible solution, and definitely need some fine tuning.
And often several solutions exist in Gerrit, even by the same person.
For my own patches, especially if they have slipped past reviewers or
it is urgent, I try to review the path with very critical eyes as if
it wasnt my own patch.
On Wed, Aug 12, 2015 at 4:55 AM, Ricordisamoa
<ricordisamoa(a)openmailbox.org> wrote:
Hi,
I'm not totally against +1 on own patches, but I've seen it used a bit
lightly.
Could you provide some examples of where you believe self +1's are
being overused?
I have a fairly constant stream of patches that I shouldn't have +1'd
as it had a problem that I hadnt noticed. And some of those are my
own patches. e.g.
https://gerrit.wikimedia.org/r/#/c/229731/ was a
particularly careless self +1.
--
John Vandenberg