Hi,
We currently have 5 reviews in the GCI queue. The oldest is https://gerrit.wikimedia.org/r/#/c/101613/
It looks good to me, except for the open question of whether the template can be localized. I suggested the student to create a localization file in i18n. If you have other suggestions, please comment.
The other reviews are: https://gerrit.wikimedia.org/r/101451 https://gerrit.wikimedia.org/r/101609 https://gerrit.wikimedia.org/r/101642 https://gerrit.wikimedia.org/r/101623
Thanks for your help, Strainu
Also https://gerrit.wikimedia.org/r/#/c/101472/
Thanks
2013/12/16 Strainu strainu10@gmail.com:
Hi,
We currently have 5 reviews in the GCI queue. The oldest is https://gerrit.wikimedia.org/r/#/c/101613/
It looks good to me, except for the open question of whether the template can be localized. I suggested the student to create a localization file in i18n. If you have other suggestions, please comment.
The other reviews are: https://gerrit.wikimedia.org/r/101451 https://gerrit.wikimedia.org/r/101609 https://gerrit.wikimedia.org/r/101642 https://gerrit.wikimedia.org/r/101623
Thanks for your help, Strainu
On 12/16/2013 02:40 PM, Strainu wrote:
We currently have 5 reviews in the GCI queue. The oldest is https://gerrit.wikimedia.org/r/#/c/101613/
The other reviews are: https://gerrit.wikimedia.org/r/101451 https://gerrit.wikimedia.org/r/101609 https://gerrit.wikimedia.org/r/101642 https://gerrit.wikimedia.org/r/101623
Thanks for your help,
Note that GCI mentors must review students tasks within 36 hours. If you can't review a Gerrit patch to the detail but you can get a good sense of the task, please evaluate either closing it as complete (and asking the student to react to feeback in Gerrit, please) or marking it as needing more work, specifying what needs improvement.
Thank you!