jenkins-bot has submitted this change and it was merged.
Change subject: (bug 65013) Test QueryGenerator.limit
......................................................................
(bug 65013) Test QueryGenerator.limit
Change-Id: I1df4c4660b47d2a43b5e6dffe76666204161d4d5
---
M tests/api_tests.py
1 file changed, 34 insertions(+), 0 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/api_tests.py b/tests/api_tests.py
index c5b02b5..510f41a 100644
--- a/tests/api_tests.py
+++ b/tests/api_tests.py
@@ -73,6 +73,40 @@
self.assertEqual(page.site, mysite)
self.assertIn(page.title(), titles)
+ def test_initial_limit(self):
+ self.assertEqual(self.gen.limit, None) # limit is initaly None
+
+ def test_limit_as_number(self):
+ for i in range(-2, 4):
+ self.gen.set_maximum_items(i)
+ self.assertEqual(self.gen.limit, i)
+
+ def test_limit_as_string(self):
+ for i in range(-2, 4):
+ self.gen.set_maximum_items(str(i))
+ self.assertEqual(self.gen.limit, i)
+
+ def test_wrong_limit_setting(self):
+ with self.assertRaisesRegexp(
+ ValueError,
+ "invalid literal for int\(\) with base 10: 'test'"):
+ self.gen.set_maximum_items('test')
+
+ def test_limits(self):
+ """Test that PageGenerator yields the requested amount of
pages"""
+ for i in range(4, 0, -1):
+ self.gen.set_maximum_items(i) # set total amount of pages
+ results = [p for p in self.gen]
+ self.assertEqual(len(results), i)
+
+ self.gen.set_maximum_items(0)
+ results = [p for p in self.gen]
+ self.assertEqual(len(results), 4) # total=0 but 4 expected (really?)
+
+ self.gen.set_maximum_items(-1)
+ results = [p for p in self.gen]
+ self.assertEqual(len(results), 4) # total=-1 but 4 expected
+
class TestCachedRequest(unittest.TestCase):
def testResults(self):
--
To view, visit
https://gerrit.wikimedia.org/r/132387
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1df4c4660b47d2a43b5e6dffe76666204161d4d5
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Russell Blau <russblau(a)imapmail.org>
Gerrit-Reviewer: jenkins-bot <>