jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/636423 ) Change subject: [IMPR] Derive NoReferencesBot from ExistingPageBot and NoRedirectPageBot ...................................................................... [IMPR] Derive NoReferencesBot from ExistingPageBot and NoRedirectPageBot Change-Id: I719bd0e928989ca2f3a8be5744175c24df82b089 --- M scripts/noreferences.py 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/noreferences.py b/scripts/noreferences.py index 1303574..c2f3544 100755 --- a/scripts/noreferences.py +++ b/scripts/noreferences.py @@ -41,7 +41,7 @@ import pywikibot from pywikibot import i18n, pagegenerators, textlib -from pywikibot.bot import SingleSiteBot +from pywikibot.bot import ExistingPageBot, NoRedirectPageBot, SingleSiteBot from pywikibot.pagegenerators import XMLDumpPageGenerator # This is required for the text that is shown when you run this script @@ -512,7 +512,7 @@ XMLDumpPageGenerator, text_predicate=_match_xml_page_text) -class NoReferencesBot(SingleSiteBot): +class NoReferencesBot(SingleSiteBot, ExistingPageBot, NoRedirectPageBot): """References section bot.""" @@ -707,32 +707,27 @@ ident=ident, text=self.referencesText) return oldText[:index].rstrip() + ref_section + oldText[index:] - def treat(self, page) -> None: + def treat_page(self) -> None: """Run the bot.""" - self.current_page = page + page = self.current_page try: text = page.text - except pywikibot.NoPage: - pywikibot.warning('Page {0} does not exist?!' - .format(page.title(as_link=True))) - return - except pywikibot.IsRedirectPage: - pywikibot.output('Page {0} is a redirect; skipping.' - .format(page.title(as_link=True))) - return except pywikibot.LockedPage: pywikibot.warning('Page {0} is locked?!' .format(page.title(as_link=True))) return + if page.isDisambig(): pywikibot.output('Page {0} is a disambig; skipping.' .format(page.title(as_link=True))) return + if self.site.sitename == 'wikipedia:en' and page.isIpEdit(): pywikibot.warning( 'Page {0} is edited by IP. Possible vandalized' .format(page.title(as_link=True))) return + if self.lacksReferences(text): newText = self.addReferences(text) try: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/636423 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I719bd0e928989ca2f3a8be5744175c24df82b089 Gerrit-Change-Number: 636423 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged