jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/902840 ) Change subject: [bugfix] Update TestOwnClient tests after repository change ...................................................................... [bugfix] Update TestOwnClient tests after repository change Bug: T333054 Change-Id: I9cf6d373af540d1f984998542bd468fb8044c047 --- M tests/wikibase_tests.py 1 file changed, 25 insertions(+), 13 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 807c28c..435ce88 100755 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -2318,36 +2318,38 @@ 'wikidata': { 'family': 'wikidata', 'code': 'wikidata', - 'title': 'Wikidata:Main Page', + 'item': 'Q32119', }, # test.wikidata is also 'wikidatatest': { 'family': 'wikidata', 'code': 'test', - 'title': r'Page \[\[(wikidata\:)?test\:Q5296\]\] ' - r'is a redirect page\.' + 'item': 'Q33', }, } def test_own_client(self, key): """Test that a data repository family can be its own client.""" site = self.get_site(key) - - page = pywikibot.Page(site, 'Wikidata:Main Page') + page = self.get_mainpage(site) item = ItemPage.fromPage(page) + self.assertEqual(page.site, site) self.assertEqual(item.site, site) def test_page_from_repository(self, key): """Test that page_from_repository method works for wikibase too.""" site = self.get_site(key) - try: - page = site.page_from_repository('Q5296') - except IsRedirectPageError: - with self.assertRaisesRegex(IsRedirectPageError, - self.sites[key]['title']): - raise - else: - self.assertEqual(page.title(), self.sites[key]['title']) + page = site.page_from_repository('Q5296') + self.assertEqual(page, self.get_mainpage(site)) + + def test_redirect_from_repository(self, key): + """Test page_from_repository method with redirects.""" + site = self.get_site(key) + item = self.sites[key]['item'] + with self.assertRaisesRegex( + IsRedirectPageError, + fr'{self.sites[key]["item"]}\]\] is a redirect'): + site.page_from_repository(item) class TestUnconnectedClient(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/902840 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I9cf6d373af540d1f984998542bd468fb8044c047 Gerrit-Change-Number: 902840 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged