jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/376061 ) Change subject: Fix regressions of api.QueryGenerator caused by 64da531a33d13b9ca ...................................................................... Fix regressions of api.QueryGenerator caused by 64da531a33d13b9ca Presence of `QueryGenerator._check_result_namespace` is not enough for calling it; `self._namespaces` must be available, too. Use `_namespaces` as the condition instead. Change-Id: Ie0d9bd027222786f969f7fa7660459b5fb810ea5 --- M pywikibot/data/api.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index c057b67..a88d9e4 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -2816,7 +2816,7 @@ self.normalized = {} for item in resultdata: result = self.result(item) - if self._check_result_namespace is not NotImplemented: + if self._namespaces: if not self._check_result_namespace(result): continue yield result -- To view, visit https://gerrit.wikimedia.org/r/376061 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d9bd027222786f969f7fa7660459b5fb810ea5 Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>