jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/656177 )
Change subject: [IMPR] simplify three tests in TestClaimSetValue
......................................................................
[IMPR] simplify three tests in TestClaimSetValue
Change-Id: I37bb142a7251c6d0e2899f231279a72b3397f53d
---
M tests/wikibase_tests.py
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index bd66528..7cff163 100644
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -1630,8 +1630,9 @@
wikidata = self.get_repo()
claim = pywikibot.Claim(wikidata, 'P856')
self.assertEqual(claim.type, 'url')
-
claim.setTarget('https://en.wikipedia.org/')
- self.assertEqual(claim.target, 'https://en.wikipedia.org/')
+ target = 'https://en.wikipedia.org/'
+ claim.setTarget(target)
+ self.assertEqual(claim.target, target)
def test_set_WbMonolingualText(self):
"""Test setting claim of monolingualtext type."""
@@ -1657,16 +1658,18 @@
wikidata = self.get_repo()
claim = pywikibot.Claim(wikidata, 'P2535')
self.assertEqual(claim.type, 'math')
- claim.setTarget('a^2 + b^2 = c^2')
- self.assertEqual(claim.target, 'a^2 + b^2 = c^2')
+ target = 'a^2 + b^2 = c^2'
+ claim.setTarget(target)
+ self.assertEqual(claim.target, target)
def test_set_identifier(self):
"""Test setting claim of external-id type."""
wikidata = self.get_repo()
claim = pywikibot.Claim(wikidata, 'P214')
self.assertEqual(claim.type, 'external-id')
- claim.setTarget('Any string is a valid identifier')
- self.assertEqual(claim.target, 'Any string is a valid identifier')
+ target = 'Any string is a valid identifier'
+ claim.setTarget(target)
+ self.assertEqual(claim.target, target)
def test_set_date(self):
"""Test setting claim of time type."""
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/656177
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I37bb142a7251c6d0e2899f231279a72b3397f53d
Gerrit-Change-Number: 656177
Gerrit-PatchSet: 1
Gerrit-Owner: Lokal Profil <andre.costa(a)wikimedia.se>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged