jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] intersect_generators must use daemon threads
......................................................................
[FIX] intersect_generators must use daemon threads
Set threads in intersect_generators() as daemon threads, so that they
are killed automatically on program exit.
With the quit mechanism implemented via QuitKeyboardInterrupt,
KeyboardInterrupt is not caught any longer in intersect_generators()
and scripts based on Bot class hang when using pagegenerators with
parameter -intersect.
Bug: T129186
Change-Id: I61b2770afce4fd0c86ca0f0a7996432375e8b18a
---
M pywikibot/tools/__init__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py
index 94a6dcd..c2c5bba 100644
--- a/pywikibot/tools/__init__.py
+++ b/pywikibot/tools/__init__.py
@@ -695,6 +695,7 @@
for source in genlist:
threaded_gen = ThreadedGenerator(name=repr(source), target=source)
+ threaded_gen.daemon = True
thrlist.append(threaded_gen)
while True:
--
To view, visit
https://gerrit.wikimedia.org/r/275718
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b2770afce4fd0c86ca0f0a7996432375e8b18a
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>