jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Fix test_preload_langlinks_count"
......................................................................
Revert "Fix test_preload_langlinks_count"
It does 'hide' the error, but that assertion doesn't make sense.
This reverts commit f6d0f0211c660ba360e9fdbeec9988ee4e1780e9.
Change-Id: Ie9c1a0f8169b55942f6bc7ea1083a91d4bda0442
---
M tests/site_tests.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index c199406..d0f85d5 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1974,8 +1974,10 @@
if count >= 6:
break
+ @allowed_failure
def test_preload_langlinks_count(self):
"""Test preloading continuation works."""
+ # FIXME: test fails
mysite = self.get_site()
mainpage = self.get_mainpage()
count = 0
@@ -1991,7 +1993,7 @@
self.assertFalse(hasattr(page, '_pageprops'))
count += 1
- self.assertEqual(len(pages), count)
+ self.assertEqual(len(links), count)
def _test_preload_langlinks_long(self):
"""Test preloading continuation works."""
--
To view, visit
https://gerrit.wikimedia.org/r/187681
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c1a0f8169b55942f6bc7ea1083a91d4bda0442
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>