jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/773925 ) Change subject: [tests] re-enable repr tests for EventStreams (Python 3.6+ only) ...................................................................... [tests] re-enable repr tests for EventStreams (Python 3.6+ only) Bug: T196311 Change-Id: I15d7ade33780fb05af6192a004aaf550adb1b90b --- M tests/eventstreams_tests.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/eventstreams_tests.py b/tests/eventstreams_tests.py index 9a1ede8..4f98954 100755 --- a/tests/eventstreams_tests.py +++ b/tests/eventstreams_tests.py @@ -10,9 +10,11 @@ from contextlib import suppress from unittest import mock -from pywikibot import config +from pywikibot import config, Site from pywikibot.comms.eventstreams import EventSource, EventStreams from pywikibot.family import WikimediaFamily +from pywikibot.tools import PYTHON_VERSION + from tests.aspects import DefaultSiteTestCase, TestCase, require_modules @@ -42,6 +44,10 @@ self.assertEqual(e._url, e.sse_kwargs.get('url')) self.assertIsNone(e._total) self.assertIsNone(e._streams) + if PYTHON_VERSION > (3, 5): + self.assertEqual(repr(e), + "EventStreams(url='{}')" + .format(self.sites[key]['hostname'])) def test_url_from_site(self, key): """Test EventStreams with url from site.""" @@ -54,6 +60,12 @@ self.assertEqual(e._url, e.sse_kwargs.get('url')) self.assertIsNone(e._total) self.assertEqual(e._streams, streams) + if PYTHON_VERSION > (3, 5): + site_repr = 'site={}, '.format( + repr(site)) if site != Site() else '' + self.assertEqual(repr(e), + "EventStreams({}streams='{}')" + .format(site_repr, streams)) @mock.patch('pywikibot.comms.eventstreams.EventSource', new=mock.MagicMock()) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/773925 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I15d7ade33780fb05af6192a004aaf550adb1b90b Gerrit-Change-Number: 773925 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged