jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1017881?usp=email )
Change subject: [IMPR] simplify code for self.settings_data in checkimages.py
......................................................................
[IMPR] simplify code for self.settings_data in checkimages.py
Change-Id: Ic0f85f07d53ac32247ff807d5574c132e17be441
---
M scripts/checkimages.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index 351a814..7950b79 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -1095,13 +1095,11 @@
self.settings_data = None
self.some_problem = False
- if not self.settings_data:
- self.settings_data = None
-
# Real-Time page loaded
if self.settings_data:
pywikibot.info('>> Loaded the real-time page... <<')
else:
+ self.settings_data = None
pywikibot.info('>> No additional settings found! <<')
def load_licenses(self) -> set[pywikibot.Page]:
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1017881?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f85f07d53ac32247ff807d5574c132e17be441
Gerrit-Change-Number: 1017881
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <dalangi-ctr(a)wikimedia.org>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged