jenkins-bot has submitted this change and it was merged.
Change subject: (bugfix) archivebot.py: use pywikibot.error
......................................................................
(bugfix) archivebot.py: use pywikibot.error
The initial port of archivebot to 'core' left in one call to
parser.error which is used for command line parsing in 'compat'.
Change-Id: Ib1e2841e7cd901a0d298852c29ef5b4025b8852e
---
M scripts/archivebot.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
Objections:
Ricordisamoa: There's a problem with this change, please improve
diff --git a/scripts/archivebot.py b/scripts/archivebot.py
index 407bd91..6fe513c 100644
--- a/scripts/archivebot.py
+++ b/scripts/archivebot.py
@@ -503,7 +503,9 @@
if calc:
if not salt:
- parser.error('Note: you must specify a salt to calculate a key')
+ pywikibot.error('Note: you must specify a salt to calculate a key')
+ return
+
s = new_hash()
s.update(salt + '\n')
s.update(calc + '\n')
--
To view, visit
https://gerrit.wikimedia.org/r/135292
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e2841e7cd901a0d298852c29ef5b4025b8852e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)live.it>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>