jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/606176 )
Change subject: [IMPR] finally close sqlite connection using with statement
......................................................................
[IMPR] finally close sqlite connection using with statement
Change-Id: I021fb05b71c82fe67b9b3e5b1763c73d474aa3ba
---
M pywikibot/version.py
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/version.py b/pywikibot/version.py
index 3806e06..0c6423e 100644
--- a/pywikibot/version.py
+++ b/pywikibot/version.py
@@ -18,6 +18,7 @@
import time
import xml.dom.minidom
+from contextlib import closing
from distutils import log
from distutils.sysconfig import get_python_lib
from io import BytesIO
@@ -182,15 +183,16 @@
# We haven't found the information in entries file.
# Use sqlite table for new entries format
from sqlite3 import dbapi2 as sqlite
- con = sqlite.connect(os.path.join(_program_dir, '.svn/wc.db'))
- cur = con.cursor()
- cur.execute("""select
+ with closing(
+ sqlite.connect(os.path.join(_program_dir, '.svn/wc.db'))) as con:
+ cur = con.cursor()
+ cur.execute("""select
local_relpath, repos_path, revision, changed_date, checksum from nodes
order by revision desc, changed_date desc""")
- name, tag, rev, date, checksum = cur.fetchone()
- cur.execute('select root from repository')
- tag, = cur.fetchone()
- con.close()
+ name, tag, rev, date, checksum = cur.fetchone()
+ cur.execute('select root from repository')
+ tag, = cur.fetchone()
+
tag = os.path.split(tag)[1]
date = time.gmtime(date / 1000000)
return tag, rev, date
--
To view, visit
https://gerrit.wikimedia.org/r/606176
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I021fb05b71c82fe67b9b3e5b1763c73d474aa3ba
Gerrit-Change-Number: 606176
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: jenkins-bot (75)