jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/691230 )
Change subject: [bugfix] Fix tests after f4ddd1f change
......................................................................
[bugfix] Fix tests after f4ddd1f change
Creating a Page raises exception if Link has no title
Change-Id: I3b50d8817c4f20514db006a6844728921457baa5
---
M tests/page_tests.py
M tests/wikibase_tests.py
2 files changed, 7 insertions(+), 10 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/page_tests.py b/tests/page_tests.py
index 87c75b2..c2de328 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -326,16 +326,20 @@
InvalidTitleError,
INVALID_TITLE_RE):
page.title()
+
page = pywikibot.page.BasePage(site, title='')
with self.assertRaisesRegex(
InvalidTitleError,
INVALID_TITLE_RE):
page.title()
- with self.assertRaisesRegex(
- ValueError,
- 'Title cannot be None.'):
+
+ with self.assertRaisesRegex(ValueError, 'Title cannot be None.'):
pywikibot.page.BasePage(site, title=None)
+ with self.assertRaisesRegex(InvalidTitleError,
+ r' contains illegal char\(s\) '):
+ pywikibot.Page(pywikibot.page.Link('[]', site))
+
def testPageConstructor(self):
"""Test Page constructor."""
site = self.get_site()
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index a8d9a16..c45544f 100644
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -1122,13 +1122,6 @@
item.get()
self.assertTrue(item.exists())
- def test_fromPage_invalid_title(self):
- """Test item from page with invalid title."""
- page = pywikibot.Page(pywikibot.page.Link('[]', self.site))
- regex = r' contains illegal char\(s\) '
- with self.assertRaisesRegex(InvalidTitleError, regex):
- ItemPage.fromPage(page)
-
def _test_fromPage_noitem(self, link):
"""Helper function to test a page without an associated item.
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/691230
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I3b50d8817c4f20514db006a6844728921457baa5
Gerrit-Change-Number: 691230
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-CC: Meno25 <meno25mail(a)gmail.com>
Gerrit-MessageType: merged