jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/810836 ) Change subject: [IMPR] exists_arg param of user_add_claim_unless_exists() must be a Container ...................................................................... [IMPR] exists_arg param of user_add_claim_unless_exists() must be a Container There is only a restriction that exists_arg param of user_add_claim_unless_exists() must be a Container. It also may be a list of atomic strings for example. (There is no tests about it valid content currently.) Change-Id: I1b09130599d6fa0a0b698a1fbbdb2a210cc3de5e --- M pywikibot/bot.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/bot.py b/pywikibot/bot.py index f401d96..f42f5b7 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -98,7 +98,7 @@ import warnings import webbrowser from collections import Counter -from collections.abc import Generator +from collections.abc import Container, Generator from contextlib import closing from functools import wraps from importlib import import_module @@ -2247,7 +2247,7 @@ def user_add_claim_unless_exists( self, item: 'pywikibot.page.ItemPage', claim: 'pywikibot.page.Claim', - exists_arg: str = '', + exists_arg: Container = '', source: Optional['BaseSite'] = None, logger_callback: Callable[[str], Any] = log, **kwargs: Any) -> bool: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/810836 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I1b09130599d6fa0a0b698a1fbbdb2a210cc3de5e Gerrit-Change-Number: 810836 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged