jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/502194 )
Change subject: [tests] Remove duplicate test methods
......................................................................
[tests] Remove duplicate test methods
test_recentchanges_ns_default and test_recentchanges_default are similar.
Bug: T220360
Change-Id: Ib9a2e1e7501c637b9d32540a731fe47584f9e997
---
M tests/pagegenerators_tests.py
1 file changed, 2 insertions(+), 10 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 041d3fb..b7c622f 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1005,14 +1005,6 @@
self.assertRaises(
ValueError, gf.handleArg, '-recentchanges:"mobile
edit,-10,20"')
- def test_recentchanges_default(self):
- """Test recentchanges generator with default
setting."""
- gf = pagegenerators.GeneratorFactory(site=self.site)
- gf.handleArg('-recentchanges:60')
- gen = gf.getCombinedGenerator()
- self.assertIsNotNone(gen)
- self.assertPagesInNamespacesAll(gen, {0, 1, 2}, skip=True)
-
def test_recentchanges_rctag(self):
"""Test recentchanges generator with recent changes
tag."""
gf = pagegenerators.GeneratorFactory(site=self.site)
@@ -1021,8 +1013,8 @@
self.assertIsNotNone(gen)
self.assertPagesInNamespacesAll(gen, {0, 1, 2}, skip=True)
- def test_recentchanges_ns_default(self):
- """Test recentchanges generator."""
+ def test_recentchanges_default(self):
+ """Test recentchanges generator with default namespace
setting."""
gf = pagegenerators.GeneratorFactory(site=self.site)
gf.handleArg('-recentchanges:50')
gen = gf.getCombinedGenerator()
--
To view, visit
https://gerrit.wikimedia.org/r/502194
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9a2e1e7501c637b9d32540a731fe47584f9e997
Gerrit-Change-Number: 502194
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)