Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1101141?usp=email )

Change subject: tests: install fake_useragent != 2.0 for Python 3.8 ......................................................................

tests: install fake_useragent != 2.0 for Python 3.8

fake_useragent is not mandatory and not part of our requirements but bundled for github action tests somehow and lead tests to fail with Python 3.8. Therefore install fake_useragent != 2.0 here.

see also https://github.com/fake-useragent/fake-useragent/issues/406

Bug: T381715 Change-Id: Iec9e0ad14b64f4a0a16de911deca7ef824dcdab4 --- M .github/workflows/pywikibot-ci.yml M .github/workflows/sysop_write_tests-ci.yml M .github/workflows/windows_tests.yml 3 files changed, 3 insertions(+), 0 deletions(-)

Approvals: jenkins-bot: Verified Xqt: Verified; Looks good to me, approved

diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index f888c0e..a51ae13 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -82,6 +82,7 @@ if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi if [ -f requirements.txt ]; then pip install -r requirements.txt; fi pip install wikitextparser + pip install "fake_useragent != 2.0; python_version=='3.8'"

- name: Install setuptools if: ${{ (matrix.python-version >= '3.12') || (matrix.os == 'macOS-latest') }} diff --git a/.github/workflows/sysop_write_tests-ci.yml b/.github/workflows/sysop_write_tests-ci.yml index a840945..d0bf618 100644 --- a/.github/workflows/sysop_write_tests-ci.yml +++ b/.github/workflows/sysop_write_tests-ci.yml @@ -44,6 +44,7 @@ pip --version if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + pip install "fake_useragent != 2.0; python_version=='3.8'"

- name: Generate user files run: | diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index 1abdf46..d927743 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -53,6 +53,7 @@ pip install -r dev-requirements.txt pip install -r requirements.txt pip install wikitextparser + pip install "fake_useragent != 2.0; python_version=='3.8'"

- name: Generate user files run: |