Xqt has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/592604 ) Change subject: Revert "SiteDetectionTestCase.assertSite: Skip tests on ConnectionError" ...................................................................... Revert "SiteDetectionTestCase.assertSite: Skip tests on ConnectionError" Do not hide exceptions during tests except they are already known for a single test and cannot be solved shortly. This reverts commit 12daad21d4c5fa06f0981d5a591a49fb998b9641. Change-Id: I5c1384d1bb39834fbdb9fb1dbbb798053253f1c9 --- M tests/site_detect_tests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py index f7b237a..bdc2039 100644 --- a/tests/site_detect_tests.py +++ b/tests/site_detect_tests.py @@ -40,7 +40,7 @@ """ try: self.assertIsInstance(MWSite(url), MWSite) - except (ServerError, Timeout, ConnectionError) as e: + except (ServerError, Timeout) as e: self.skipTest(e) def assertNoSite(self, url): -- To view, visit https://gerrit.wikimedia.org/r/592604 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c1384d1bb39834fbdb9fb1dbbb798053253f1c9 Gerrit-Change-Number: 592604 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)