jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/434843 ) Change subject: paraminfo_tests.py: Add 'form' and 'lexeme' to unsupported types ...................................................................... paraminfo_tests.py: Add 'form' and 'lexeme' to unsupported types The feature has been released on production sites. Bug: T194890 Change-Id: I4139f5a9e5307fe744abdee271ad5c6a43cbd146 --- M tests/paraminfo_tests.py 1 file changed, 5 insertions(+), 13 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/paraminfo_tests.py b/tests/paraminfo_tests.py index 121e0ff..f815251 100644 --- a/tests/paraminfo_tests.py +++ b/tests/paraminfo_tests.py @@ -220,19 +220,11 @@ def test_entities(self): """Test known entities.""" - unsupported = [] - - if self.site.sitename in ('test:test', 'wikidata:test'): - unsupported = ['form', 'lexeme'] # T194890 - - supported = ['item', 'property'] - known = supported + unsupported - if unsupported: - self._check_param_superset( - self.repo, 'wbsearchentities', 'type', known) - else: - self._check_param_values( - self.repo, 'wbsearchentities', 'type', known) + unsupported = {'form', 'lexeme'} # T195435 + supported = {'item', 'property'} + known = supported | unsupported + self._check_param_superset( + self.repo, 'wbsearchentities', 'type', known) # Missing datatypes won't crash pywikibot but should be noted def test_datatypes(self): -- To view, visit https://gerrit.wikimedia.org/r/434843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4139f5a9e5307fe744abdee271ad5c6a43cbd146 Gerrit-Change-Number: 434843 Gerrit-PatchSet: 3 Gerrit-Owner: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>